Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-983

Expose cleanshutdown method in MirrorMaker at the object level

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      Making clean shutdown in MirrorMaker public at the object level will be useful. Currently if MirrorMaker is run in a container process, the only way to stop it seems to be triggering the shutdown hook (System.exit(0)) which may have unwarranted side effects on the other threads running in that container process.

      Attachments

        1. KAFKA-983.patch
          2 kB
          Swapnil Ghike
        2. KAFKA-983-rebased.patch
          3 kB
          Swapnil Ghike

        Activity

          guozhang Guozhang Wang added a comment -

          +1. Looks good to me.

          guozhang Guozhang Wang added a comment - +1. Looks good to me.

          +1 - can you rebase? Also, may be better to have an if null check in the shutdown statements.

          jjkoshy Joel Jacob Koshy added a comment - +1 - can you rebase? Also, may be better to have an if null check in the shutdown statements.
          swapnilghike Swapnil Ghike added a comment -

          rebased.

          swapnilghike Swapnil Ghike added a comment - rebased.

          Thanks for the patch. Committed to 0.8

          jjkoshy Joel Jacob Koshy added a comment - Thanks for the patch. Committed to 0.8

          People

            swapnilghike Swapnil Ghike
            swapnilghike Swapnil Ghike
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: