Kafka
  1. Kafka
  2. KAFKA-983

Expose cleanshutdown method in MirrorMaker at the object level

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Making clean shutdown in MirrorMaker public at the object level will be useful. Currently if MirrorMaker is run in a container process, the only way to stop it seems to be triggering the shutdown hook (System.exit(0)) which may have unwarranted side effects on the other threads running in that container process.

      1. KAFKA-983.patch
        2 kB
        Swapnil Ghike
      2. KAFKA-983-rebased.patch
        3 kB
        Swapnil Ghike

        Activity

        Swapnil Ghike created issue -
        Swapnil Ghike made changes -
        Field Original Value New Value
        Attachment KAFKA-983.patch [ 12593592 ]
        Swapnil Ghike made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Guozhang Wang added a comment -

        +1. Looks good to me.

        Show
        Guozhang Wang added a comment - +1. Looks good to me.
        Hide
        Joel Koshy added a comment -

        +1 - can you rebase? Also, may be better to have an if null check in the shutdown statements.

        Show
        Joel Koshy added a comment - +1 - can you rebase? Also, may be better to have an if null check in the shutdown statements.
        Hide
        Swapnil Ghike added a comment -

        rebased.

        Show
        Swapnil Ghike added a comment - rebased.
        Swapnil Ghike made changes -
        Attachment KAFKA-983-rebased.patch [ 12594076 ]
        Joel Koshy made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Joel Koshy added a comment -

        Thanks for the patch. Committed to 0.8

        Show
        Joel Koshy added a comment - Thanks for the patch. Committed to 0.8
        Joel Koshy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development