[KAFKA-4922] Fix several FindBugs warnings in Clients and Connect - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 0.10.2.0
Fix Version/s: 0.11.0.0
Component/s: clients, connect
Labels:
- newbie
Environment:
Identified by FindBugs, non-software and -platform specific

Description

Four easy to fix warnings (not a complete set of the current FindBugs warnings) as identified by FindBugs and stated in the attached reports:
-org.apache.kafka.common.utils.Bytes.equals(Object) does not check for null argument (Low priority, Bad Practice)
-Primitive boxed just to call toString in org.apache.kafka.connect.data.Decimal.builder(int) (High Priority, Performance)
-Primitive boxed just to call toString in new org.apache.kafka.connect.runtime.Worker(String, Time, ConnectorFactory, WorkerConfig, OffsetBackingStore) (High Priority, Performance)
-Primitive is boxed to call Integer.compareTo(Integer): use Integer.compare(int, int) instead (High Priority, Performance)