Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4922

Fix several FindBugs warnings in Clients and Connect

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.10.2.0
    • 0.11.0.0
    • clients, connect
    • Identified by FindBugs, non-software and -platform specific

    Description

      Four easy to fix warnings (not a complete set of the current FindBugs warnings) as identified by FindBugs and stated in the attached reports:
      -org.apache.kafka.common.utils.Bytes.equals(Object) does not check for null argument (Low priority, Bad Practice)
      -Primitive boxed just to call toString in org.apache.kafka.connect.data.Decimal.builder(int) (High Priority, Performance)
      -Primitive boxed just to call toString in new org.apache.kafka.connect.runtime.Worker(String, Time, ConnectorFactory, WorkerConfig, OffsetBackingStore) (High Priority, Performance)
      -Primitive is boxed to call Integer.compareTo(Integer): use Integer.compare(int, int) instead (High Priority, Performance)

      Attachments

        1. ConnectRuntimeFindBugsReport.html
          46 kB
          Daan Rennings
        2. ConnectAPIFindBugsReport.html
          17 kB
          Daan Rennings
        3. ClientsFindBugsReport.html
          114 kB
          Daan Rennings

        Activity

          People

            Unassigned Unassigned
            drennings Daan Rennings
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: