Uploaded image for project: 'Jackrabbit FileVault'
  1. Jackrabbit FileVault
  2. JCRVLT-289

InstallHooks: Propagate exceptions also for phase INSTALL

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.44
    • Fix Version/s: 3.2
    • Component/s: Packaging
    • Labels:
      None

      Description

      Currently only exceptions in phase PREPARE lead to a failure on the client side (https://github.com/apache/jackrabbit-filevault/blob/a64860257de2450f804b0cdf55a5afc8686b2636/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L150). But also errors in phase lifecyle should be propagated to the called, otherwise the caller cannot know whether the execution of the hook was successful or not.

      Therefore, exceptions in that phase within InstallHookProcessorImpl.execute(...) should also lead to a return value of false. In addition the return value needs to be evaluated in https://github.com/apache/jackrabbit-filevault/blob/9eb53d36adfb7695a44075c72ca7ff0cedafabcc/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L241.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                kwin Konrad Windszus
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: