[JCRVLT-440] Do not treat Throwables differently than PackageExceptions in Hooks

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.4
• Fix Version/s: 3.4.6
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 27/May/20 11:26
• Updated: 03/Aug/20 20:02
• Resolved: 02/Jun/20 14:48

Description

Currently only PackageExceptions in hooks leads to package installation failures. All Throwable s are basically silently ignored (with just a small warning) at https://github.com/apache/jackrabbit-filevault/blob/38ab44e815e114479dcf06dabfbfd5a1898a192f/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L152.

IMHO all exceptions should lead to package installation failures which are also propagated to the client.

Issue Links

• relates to: JCRVLT-289 InstallHooks: Propagate exceptions also for phase INSTALL