[JCR-4018] Consistent Async Upload Executor handling in Backend implementations

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.13.4, 2.14
• Labels: PatchAvailable
• Assignee: Amit Jain
• Reporter: Woonsan Ko
• Created: 07/Sep/16 17:16
• Updated: 10/Nov/16 09:16
• Resolved: 15/Sep/16 04:58

Description

There are some inconsistent configuration/behaviors regarding asynchronous upload executor handling.
For example,

• VFSBackend disables async upload based on asyncPoolSize not based on CachingDataStore#asyncUploadLimit.
• FSBackend disables it based on CachingDataStore#asyncUploadLimit correctly as of JCR-4008.
• S3Backend doesn't have a feature to disable async uploading yet.

Probably it would be nicer to have AbstractBackend for all the practical Backend implementations to share the handling on asynchronous uploading features such as how to create an Executor and async executor pool size, etc. There are already some duplicate code regarding this in VFSBackend and FSBackend.

Issue Links

• relates to: JCR-4008 Restore TestCachingFDS.testDeleteRecord() to fix it with disabling AsyncUpload in unit tests
• links to: GitHub Pull Request #43