[JCR-4008] Restore TestCachingFDS.testDeleteRecord() to fix it with disabling AsyncUpload in unit tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.13.2
• Fix Version/s: 2.13.4, 2.14, 2.12.10, 2.10.9
• Assignee: Amit Jain
• Reporter: Woonsan Ko
• Created: 29/Aug/16 12:22
• Updated: 11/Jan/19 13:30
• Resolved: 09/Sep/16 03:28

Description

The test used to fail occasionally before the test method was commented out by JCR-4006:

junit.framework.AssertionFailedError: rec2 should be null
	at junit.framework.Assert.fail(Assert.java:50)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at junit.framework.Assert.assertNull(Assert.java:237)
	at org.apache.jackrabbit.core.data.TestCaseBase.doDeleteRecordTest(TestCaseBase.java:327)
	at org.apache.jackrabbit.core.data.TestCaseBase.testDeleteRecord(TestCaseBase.java:192)

The main reason of this error is because the underlying backend uses asynchronous writing threads by default, which is not working well when extending org.apache.jackrabbit.core.data.TestCaseBase as mentioned in JCR-4005.
So, it seems better to fix it again like the following like how JCR-4005 was fixed:

• Restore the commented out block (TestCachingFDS.testDeleteRecord()).
• Provide an option to disable asynchronous writing in all the related backend implementations. e.g., disable it if asyncWritePoolSize is zero or smaller.
• In unit tests, simply disable async writing.

Issue Links

• is related to: JCR-3944 CachingDataStore - Disable AsyncUploadCache
• is related to: JCR-4018 Consistent Async Upload Executor handling in Backend implementations
• links to: GitHub Pull Request #40
• links to: GitHub Pull Request #42