[IO-544] Should FileUtils.copyFile be flushed and synced before comparing file sizes?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.12.0
• Component/s: Utilities

Environment

Win Server 2008, x86

• Assignee: Unassigned
• Reporter: Sean Poulter
• Created: 05/Jul/17 18:22
• Updated: 08/Aug/22 13:43
• Resolved: 08/Aug/22 13:43

Description

I've been struggling to troubleshoot intermittent IOExceptions thrown from FileUtils.doCopyFile when copying 2-4KB files from a local temporary file to a network drive. Despite the error, the file appears on the network drive when I check. Should the output channel/buffer be forced/flushed before closing, and synchronized before comparing the file lengths? It's a rather intermittent issue on a relatively high throughput PC so I'd expect there to be more IO latency than normal.

I found myself referencing:

• The source code for FileUtils v2.5
• FileChannel#force(boolean)
• IO-443 - FileUtils.copyFile methods throw an unnecessary "Failed to copy full contents from" exception

Thanks,
Sean

Issue Links

• is related to: IO-443 FileUtils.copyFile methods throw an unnecessary "Failed to copy full contents from" exception
• is related to: IO-386 FileUtils.doCopyFile uses different methods to check the file sizes