[IO-386] FileUtils.doCopyFile uses different methods to check the file sizes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.12.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 02/Jun/13 13:37
• Updated: 08/Aug/22 14:33
• Resolved: 08/Aug/22 14:33

Description

FileUtils.doCopyFile uses FileChannel.size() to measure the input file length at the start, and File.length() to compare the lengths at the end.

This is inconsistent.
If there is a good reason for this it should be documented, otherwise it should probably use the same method for all the checks.
[Note: is FileChannel.size() accurate if the file has not been flushed?]

Issue Links

• relates to: IO-443 FileUtils.copyFile methods throw an unnecessary "Failed to copy full contents from" exception
• relates to: IO-544 Should FileUtils.copyFile be flushed and synced before comparing file sizes?
• relates to: IO-604 FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException