Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-9362

Update sqlparse used by impala-shell from version 0.1.19 to latest

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 3.4.0
    • Impala 4.0.0
    • Clients
    • None
    • ghx-label-9

    Description

      The fix for IMPALA-6337 involved correcting the way that sqlparse, an upstream 3rd party python library used by the impala-shell, parses queries that contain line breaks embedded inside of double quotes. Initially, Impala's internally bundled version of sqlparse (based on 0.1.19) was patched; meanwhile, a pull request to get the fix into an official release was submitted.

      That pull-request was finally included in the 0.3.0 version of sqlparse. However, there were other changes to the library in the interim, in terms of API's and also in some of the parsing logic, that breaks the impala-shell in other ways, so simply migrating to the newer release is not straightforward.

      We need to find and fix all the places that the newer sqlparse breaks the impala-shell, so that we can stop relying on sqlparse 0.1.19 (which, in some places, is not python 3 compatible).

      Attachments

        Issue Links

          Activity

            People

              dknupp David Knupp
              dknupp David Knupp
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: