[IMPALA-7524] Keep frame pointers for generated code

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Impala 2.13.0, Impala 3.1.0
• Component/s: Backend
• Labels: codegen
• Epic Color: ghx-label-7
• Assignee: Unassigned
• Reporter: Lars Volker
• Created: 04/Sep/18 16:35
• Updated: 15/Feb/23 03:17

Description

Generated code does not preserve the frame pointer and thus stack unwinding does not work when we crash in generated functions. We should preserve the frame pointers to make debugging easier. Kudu's experience and our own in IMPALA-4132 suggest that the performance hit will be tolerable (but we still should do a proper perf evaluation).

Here's Kudu's way of preserving the frame pointers: module_builder.cc:294.

Thanks tlipcon for the suggestion.

Issue Links

• is related to: IMPALA-11222 Use -fno-omit-frame-pointer for LLVM IR generation