[IMPALA-4132] Consider using -fno-omit-frame-pointer in release builds

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.7.0
• Fix Version/s: Impala 3.0, Impala 2.12.0
• Component/s: Infrastructure
• Labels: breakpad supportability
• Assignee: Gabor Kaszab
• Reporter: Silvius Rus
• Created: 14/Sep/16 19:00
• Updated: 14/Feb/18 21:19
• Resolved: 14/Feb/18 21:19

Description

We're currently building with -fomit-frame-pointer, which can lead to cryptic stack traces.

Switching to -fno-omit-frame-pointer will produce better stack traces but cost some performance. In my past experience, on x86-64 the penalty was around 0.5% (though on different code and with a different register allocator) which I think is a reasonably tradeoff but in corner cases it can be higher. So we'd need to qualify this change through a perf regression run (both benchmarks and primitives).