[IMPALA-12779] lock_max_wait_time_s is not set for ComputeStats

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Catalog
• Epic Color: ghx-label-5
• Assignee: Unassigned
• Reporter: Quanlong Huang
• Created: 02/Feb/24 01:20
• Updated: 03/Feb/24 00:37

Description

While showing non-default options in the /operations webUI of catalogd, I found ComputeStats statements all have lock_max_wait_time_s=0. The default value is 300.

Should we set the default value (300) in TDdlQueryOptions? boroknagyz

// Subset of query options passed to DDL operations
struct TDdlQueryOptions {
  // True if SYNC_DDL is set in query options
  1: required bool sync_ddl
  
  // Passes the debug actions to catalogd if the query option is set. 
  2: optional string debug_action
  
  // Maximum wait time on an HMS ACID lock in seconds.
  3: optional i32 lock_max_wait_time_s

  // The reservation time (in seconds) for deleted impala-managed kudu table.
  // During this time deleted Kudu tables can be recovered by Kudu's 'recall table' API.
  // See KUDU-3326 for details.
  4: optional i32 kudu_table_reserve_seconds
}

https://github.com/apache/impala/blob/b094f0e2e7ca32f177b3f065612e8f019f080154/common/thrift/CatalogService.thrift#L110
We set the default value in TQueryOptions:
https://github.com/apache/impala/blob/b094f0e2e7ca32f177b3f065612e8f019f080154/common/thrift/Query.thrift#L616

Issue Links

• Discovered while testing: IMPALA-12780 Only show non-default options in the catalog operations page
• relates to: IMPALA-11153 Expose LOCK_RETRIES/LOCK_RETRY_WAIT_SECONDS settings for user