[IMPALA-11153] Expose LOCK_RETRIES/LOCK_RETRY_WAIT_SECONDS settings for user

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.1.0
• Component/s: Catalog, Frontend
• Labels: ramp-up
• Epic Color: ghx-label-13
• Assignee: Zoltán Borók-Nagy
• Reporter: Zoltán Borók-Nagy
• Created: 25/Feb/22 10:55
• Updated: 02/Feb/24 01:21
• Resolved: 07/Apr/22 07:58

Description

Impala using private static final value for lock retry/wait.

https://github.com/apache/impala/blob/873fe2e5241c5714dfd94a186d524edc1cbad0ad/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java#L142

// Number of retries to acquire an HMS ACID lock.
private static final int LOCK_RETRIES = 10;

// Time interval between retries of acquiring an HMS ACID lock
private static final int LOCK_RETRY_WAIT_SECONDS = 3;

In some cases it would make sense to make these values tunable.

We invoke acquireLock() in these places:
https://github.infra.cloudera.com/CDH/Impala/blob/3ceabc01822f53bb6f174dc29aac56ac3993d389/fe/src/main/java/org/apache/impala/service/Frontend.java#L2169

https://github.infra.cloudera.com/CDH/Impala/blob/7ae6fff71c860f7623fc0bfd3092073128c4959c/fe/src/main/java/org/apache/impala/catalog/Catalog.java#L745
invoked by
https://github.infra.cloudera.com/CDH/Impala/blob/ac62b98ab1d3475d8ece865c67fe90d463c340b5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L1936

In Frontend.java it's easy to access the query options. To have the tunables at the CatalogD -side we probably need to extend TDropTableOrViewParams or TDdlExecRequest.

Issue Links

• is related to: IMPALA-12779 lock_max_wait_time_s is not set for ComputeStats