[IMPALA-11308] Shell tests fail when run with a python3 install of impala-shell

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: Impala 4.1.0
• Fix Version/s: Not Applicable
• Component/s: Clients
• Epic Color: ghx-label-10
• Assignee: Michael Smith
• Reporter: Michael Smith
• Created: 20/May/22 23:05
• Updated: 05/Dec/22 17:55
• Resolved: 05/Dec/22 17:55

Description

27 shell test scenarios fail when running impala-py.test tests/shell with a python3 installation of impala-shell.

AIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling[strict_hs2_protocol: False | protocol: beeswax]
FAIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling[strict_hs2_protocol: True | protocol: hs2]
FAIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling[strict_hs2_protocol: True | protocol: hs2-http]
FAIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_commandline.py::TestImpalaShell::()::test_http_socket_timeout[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_reconnect[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_reconnect[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_ddl_queries_are_closed[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_ddl_queries_are_closed[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_multiline_queries_in_history[strict_hs2_protocol: False | protocol: beeswax]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_multiline_queries_in_history[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_multiline_queries_in_history[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_history_does_not_duplicate_on_interrupt[strict_hs2_protocol: False | protocol: beeswax]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_history_does_not_duplicate_on_interrupt[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_history_does_not_duplicate_on_interrupt[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_rerun[strict_hs2_protocol: False | protocol: beeswax]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_rerun[strict_hs2_protocol: False | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_rerun[strict_hs2_protocol: False | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_commandline_flag_disable_live_progress[strict_hs2_protocol: True | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_commandline_flag_disable_live_progress[strict_hs2_protocol: True | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_commandline_flag_strict_hs2_protocol[strict_hs2_protocol: True | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_commandline_flag_strict_hs2_protocol[strict_hs2_protocol: True | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_live_option_configuration[strict_hs2_protocol: True | protocol: hs2]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_live_option_configuration[strict_hs2_protocol: True | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_http_interactions_extra[strict_hs2_protocol: True | protocol: hs2-http]
FAIL tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_http_interactions_extra[strict_hs2_protocol: False | protocol: hs2-http]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: beeswax]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: beeswax]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: True | protocol: hs2]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: True | protocol: hs2]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: True | protocol: hs2-http]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: True | protocol: hs2-http]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: hs2-http]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: hs2-http]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: hs2]
ERROR tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::()::test_line_with_leading_comment[strict_hs2_protocol: False | protocol: hs2] 

Steps to reproduce:
1. build an impala-shell archive; make shell_pypi_package mostly works for me
2. pip3 install shell/dist/impala_shell-<version>.tar.gz (optionally use a venv)
3. start an impala cluster
4. run impala-py.test --shell_executable=/path/to/impala-shell tests/shell (likely installed to ~/.local/bin/impala-shell)

Full test output attached.

Issue Links

• relates to: IMPALA-3343 Impala-shell compatibility with python 3
• relates to: IMPALA-11313 impala-shell's PyPi form factor still suffers from IMPALA-10299
• relates to: IMPALA-11249 Precommits are not running strict_hs2_protocol=True configurations for shell tests
• relates to: IMPALA-11251 TestImpalaShellInteractive.test_unicode_input fails on Ubuntu 20
• relates to: IMPALA-11315 TestImpalaShellInteractive.test_multiline_queries_in_history fails with python3
• relates to: IMPALA-11316 TestImpalaShell.test_http_socket_timeout fails on Python3 with different message
• relates to: IMPALA-11317 TestImpalaShellInteractive.test_http_interactions_extra fails on Python 3