[IMPALA-11249] Precommits are not running strict_hs2_protocol=True configurations for shell tests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.1.0
• Fix Version/s: Impala 4.2.0, Impala 4.1.1
• Component/s: Clients
• Epic Color: ghx-label-2
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 18/Apr/22 17:06
• Updated: 26/Aug/22 00:08
• Resolved: 27/May/22 16:32

Description

When debugging a shell test failure, I noticed that the set of tests running in precommit is different from what happens when I run in my development environment. In precommit, none of the strict_hs2_protocol=True shell tests run. I can't figure out why it behaves that way from the code, given that we enable this test dimension:

  def add_test_dimensions(cls):
    # Run with both beeswax and HS2 to ensure that behaviour is the same.
    cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
    cls.ImpalaTestMatrix.add_dimension(create_client_protocol_strict_dimension())
    cls.ImpalaTestMatrix.add_constraint(lambda v:
          v.get_value('protocol') != 'beeswax' or not v.get_value('strict_hs2_protocol'))

And create_client_protocol_strict_dimension() should produce both False and True:

def create_client_protocol_strict_dimension():
  # only support strict dimensions if the file system is HDFS, since that is
  # where the hive cluster is run.
  if IS_HDFS:
    return ImpalaTestDimension('strict_hs2_protocol', False, True)
  else:
    return create_client_protocol_no_strict_dimension()

When I run locally, those tests run (and there are some failures to fix).

Example precommit job: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16296/testReport/shell.test_shell_interactive/TestImpalaShellInteractive/

Issue Links

• is related to: IMPALA-11308 Shell tests fail when run with a python3 install of impala-shell