[IGNITE-6804] Print a warning if HashMap is passed into bulk update operations

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.9
• Component/s: cache
• Labels: usability
• Release Note: Print development warning of deadlock when unordered collection is passed to putAll-style bulk cache operation.
• Assignee: Ilya Kasnacheev
• Reporter: Denis A. Magda
• Reviewer: Andrey N. Gura
• Created: 31/Oct/17 17:33
• Updated: 13/Nov/20 15:27
• Resolved: 11/Feb/20 13:38

Description

Ignite newcomers tend to stumble on deadlocks simply because the keys are passed in an unordered HashMap. Propose to do the following:

• update bulk operations Java docs.
• print out a warning if not SortedMap (e.g. HashMap, Weak/Identity/Concurrent/Linked HashMap etc) is passed into
  a bulk method (instead of SortedMap) and contains more than 1 element. However, we should make sure that we only print that warning once and not every time the API is called.
• do not produce warning for explicit optimistic transactions

More details are here:
http://apache-ignite-developers.2346864.n4.nabble.com/Re-Ignite-2-0-0-GridUnsafe-unmonitor-td23706.html

Issue Links

• blocks: IGNITE-12365 Concurrent removeAll() on the same cache leads to deadlock
• is blocked by: IGNITE-12451 Introduce deadlock detection for cache entry reentrant locks
• is duplicated by: IGNITE-11558 Developer warning when HashMap is passed to putAll()
• is related to: IGNITE-13653 Don't print warning if unordered map used for bulk update operation on atomic cache
• relates to: IGNITE-13706 Thin Client Put_All uses LinkedHashMap, causes warning and may deadlock
• relates to: IGNITE-12296 .NET: Implement Log Throttle and print warning for unsafe PutAll ops
• relates to: IGNITE-7608 Sort keys in putAll/removeAll methods
• links to: GitHub Pull Request #6976