[IGNITE-11558] Developer warning when HashMap is passed to putAll()

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7
• Component/s: cache
• Assignee: Ilya Kasnacheev
• Reporter: Ilya Kasnacheev
• Created: 18/Mar/19 09:44
• Updated: 13/Dec/19 16:42
• Resolved: 05/Sep/19 13:12

Description

Currently when HashMap is passed to putAll it's very easy to cause deadlock since the order of keys is not stable.

This is a pity because users will use HashMap by default and not expect any trouble.

We should issue a warning when user passes HashMap (but not LinkedHashMap) to putAll(). On .Net we should probably check for Dictionary. Warning similar to the one issues when index cannot be efficiently inlined.

Another approach is to turn keys into binary form and then sort them, if map is not a SortedMap.

Issue Links

• duplicates: IGNITE-6804 Print a warning if HashMap is passed into bulk update operations
• is blocked by: IGNITE-12451 Introduce deadlock detection for cache entry reentrant locks