[IGNITE-24060] Scale down timer are not working for HA zones

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: ignite-3
• Epic Link: Partition Majority Unavailability
• Assignee: Kirill Gusakov
• Reporter: Kirill Gusakov
• Created: 20/Dec/24 11:41
• Updated: 2 days ago 11:17
• Resolved: 2 days ago 11:17

Description

During the IGNITE-24018 we discovered, that scale down is not working for HA zones. The root cause is the following code in DistributionZoneManager

if (nodesRemoved) {
    if (zone.consistencyMode() == HIGH_AVAILABILITY) {
        if (partitionReset != INFINITE_TIMER_VALUE) {
            zonesState.get(zoneId).reschedulePartitionDistributionReset(
                    partitionReset,
                    () -> fireTopologyReduceLocalEvent(revision, zoneId),
                    zoneId
            );
        }
    } else {
        if (autoAdjustScaleDown == IMMEDIATE_TIMER_VALUE) {
            futures.add(saveDataNodesToMetaStorageOnScaleDown(zoneId, revision));
        }

        if (autoAdjustScaleDown != INFINITE_TIMER_VALUE) {
            zonesState.get(zoneId).rescheduleScaleDown(
                    autoAdjustScaleDown,
                    () -> saveDataNodesToMetaStorageOnScaleDown(zoneId, revision),
                    zoneId
            );
        }
    }
}

Definition of done

• Scaledown timers are working for HA case also and appropriate tests added

Issue Links

• breaks: IGNITE-24018 Tests from DistributionZoneManager must work for HA zones
• links to: GitHub Pull Request #4973