[IGNITE-10927] Relieve JUnit3TestLegacySupport from inheriting deprecated junit.framework.Assert (follow-up to IGNITE-10177)

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.8
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 14/Jan/19 12:04
• Updated: 04/Feb/19 19:33
• Resolved: 04/Feb/19 19:30

Description

JUnit3TestLegacySupport currently inherits deprecated junit.framework.Assert. This was done only in order to minimize risky code changes when tests were migrating from Junit 3, after GridAbstractTest has dropped inheriting junit.framework.TestCase.

Now that migration is over it is less risky to cleanup project from deprecated assert methods and drop the harmful inheritance. In order to make this smoother and minimize amount of test changes, after inheritance is dropped, JUnit3TestLegacySupport should be extended with a set of "temporary patch" methods that would delegate most popular assertions used by subclasses to respective methods of org.junit.Assert.

Mentioned temporary patch methods, in turn, should respective 2deprecation notices in javadocs that would encourage developers to (safely and gradually) change them to direct invocations and static imports of respective Assert methods instead of using those inherited from superclass. These patch methods should be declared protected final or protected static, in order to minimize their applicability and prevent them spreading more than intended. (as a side note, experimenting has shown that use of @Deprecated annotation is not feasible as it deprives developers an option to use static imports)

Issue Links

• is duplicated by: IGNITE-11116 replace Assert in particular test classes from junit.framework (JUnit 3) to org.junit (JUnit 4)
• relates to: IGNITE-11116 replace Assert in particular test classes from junit.framework (JUnit 3) to org.junit (JUnit 4)
• links to: GitHub Pull Request #5866