[IGNITE-11116] replace Assert in particular test classes from junit.framework (JUnit 3) to org.junit (JUnit 4)

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 29/Jan/19 08:18
• Updated: 31/Jan/19 10:17
• Resolved: 31/Jan/19 10:17

Description

Some tests start failing on Teamcity when Assert is replaced to one from org.junit package (note I couldn't reliably reproduce these failures locally). Per my observations it looks like troublesome code involves assertEquals that compares double / float values with non-zero delta. This issue was discovered in the course of IGNITE-10927.

Search in the PR 5866 linked to IGNITE-10927 for import of junit.framework.Assert shows that this involves ZookeeperDiscoverySpiTestHelper, IoStatisticsMetricsLocalMXBeanImplSelfTest, BinaryMarshallerSelfTest, RestMemcacheProtocolSelfTest.

Search in this PR for static import of junit.framework.Assert shows 12 more involved test classes, CassandraConfigTest, ClientCacheFlagsCodecTest etc.

Issue Links

• duplicates: IGNITE-10927 Relieve JUnit3TestLegacySupport from inheriting deprecated junit.framework.Assert (follow-up to IGNITE-10177)
• is related to: IGNITE-10927 Relieve JUnit3TestLegacySupport from inheriting deprecated junit.framework.Assert (follow-up to IGNITE-10177)