Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
2.8
-
None
Description
This task is to migrate config variations test suites from JUnit 3 to 4.
If needed, refer parent task comments for more details.
Note this might be somewhat tough nut to crack design wise since JUnit4TestAdapter plays a special role in config variations tests, see IGNITE-10739.
Attachments
Attachments
Issue Links
- is related to
-
IGNITE-10739 get rid of using JUnit 3 API in IgniteConfigVariationsAbstractTest
- Resolved
- links to
Activity
ASF GitHub Bot
made changes -
Worklog Id | 189542 [ 189542 ] | |
Time Spent | 20m [ 1200 ] | 0.5h [ 1800 ] |
ASF GitHub Bot
logged work - 24/Jan/19 16:00
-
- Time Spent:
- 10m
-
asfgit commented on pull request #5781:
IGNITE-10776Migrate from JUnit 3 to 4 config variations test suites
URL: https://github.com/apache/ignite/pull/5781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
ASF GitHub Bot
made changes -
Remote Link | This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] | This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] |
Ilya Kasnacheev
made changes -
Resolution | Fixed [ 1 ] | |
Status | Patch Available [ 10002 ] | Resolved [ 5 ] |
Oleg Ignatenko
made changes -
Status | In Progress [ 3 ] | Patch Available [ 10002 ] |
Oleg Ignatenko
made changes -
Status | Patch Available [ 10002 ] | In Progress [ 3 ] |
ASF GitHub Bot
made changes -
Worklog Id | 188889 [ 188889 ] | |
Time Spent | 10m [ 600 ] | 20m [ 1200 ] |
ASF GitHub Bot
logged work - 23/Jan/19 12:26
-
- Time Spent:
- 10m
-
sergey-chugunov-1985 commented on pull request #5781:
IGNITE-10776Migrate from JUnit 3 to 4 config variations test suites
URL: https://github.com/apache/ignite/pull/5781#discussion_r250173787
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheReadThroughEvictionsVariationsSuite.java
##########
@@ -17,26 +17,21 @@
package org.apache.ignite.internal.processors.cache;
-import junit.framework.TestSuite;
+import java.util.List;
import org.apache.ignite.configuration.IgniteConfiguration;
import org.apache.ignite.internal.binary.BinaryMarshaller;
import org.apache.ignite.lang.IgnitePredicate;
import org.apache.ignite.testframework.configvariations.ConfigVariationsTestSuiteBuilder;
import org.junit.runner.RunWith;
-import org.junit.runners.AllTests;
+import org.junit.runners.Suite;
+import org.junit.runners.model.InitializationError;
-/**
- *
- */
-@RunWith(AllTests.class)
+/** */
+@RunWith(IgniteCacheReadThroughEvictionsVariationsSuite.DynamicSuite.class)
public class IgniteCacheReadThroughEvictionsVariationsSuite {
Review comment:
It seems logical to move this test to the testsuites package where other suite classes reside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
ASF GitHub Bot
made changes -
Remote Link | This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] | This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] |
Oleg Ignatenko
made changes -
Status | In Progress [ 3 ] | Patch Available [ 10002 ] |
Oleg Ignatenko
made changes -
Status | Patch Available [ 10002 ] | In Progress [ 3 ] |
Oleg Ignatenko
made changes -
Fix Version/s | 2.8 [ 12343972 ] |
Oleg Ignatenko
made changes -
Status | In Progress [ 3 ] | Patch Available [ 10002 ] |
ASF GitHub Bot
made changes -
Worklog Id | 181751 [ 181751 ] | |
Remaining Estimate | 0h [ 0 ] | |
Time Spent | 10m [ 600 ] |
ASF GitHub Bot
logged work - 07/Jan/19 13:26
-
- Time Spent:
- 10m
-
oignatenko commented on pull request #5781:
IGNITE-10776Migrate from JUnit 3 to 4 config variations test suites
URL: https://github.com/apache/ignite/pull/5781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
ASF GitHub Bot
made changes -
Remote Link | This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] |
Oleg Ignatenko
made changes -
Status | Open [ 1 ] | In Progress [ 3 ] |
Oleg Ignatenko
made changes -
Assignee | Oleg Ignatenko [ oignatenko ] |
Alexey Goncharuk
made changes -
Summary | migrate from JUnit 3 to 4 config variations test suites | Migrate from JUnit 3 to 4 config variations test suites |
Oleg Ignatenko
made changes -
Link |
This issue is related to |
Oleg Ignatenko
made changes -
Ignite Flags | Docs Required [ 12560 ] |
Oleg Ignatenko
made changes -
Field | Original Value | New Value |
---|---|---|
Labels | MakeTeamcityGreenAgain |
Oleg Ignatenko
created issue -
Oleg Ignatenko thank you for contribution! I have merged it to master.