Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.8
    • 2.8
    • None

    Description

      This task is to migrate config variations test suites from JUnit 3 to 4.

      If needed, refer parent task comments for more details.

      Note this might be somewhat tough nut to crack design wise since JUnit4TestAdapter plays a special role in config variations tests, see IGNITE-10739.

      Attachments

        Issue Links

        Activity

          githubbot ASF GitHub Bot made changes -
          Worklog Id 189542 [ 189542 ]
          Time Spent 20m [ 1200 ] 0.5h [ 1800 ]
          githubbot ASF GitHub Bot logged work - 24/Jan/19 16:00
          • Time Spent:
            10m
             
            asfgit commented on pull request #5781: IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites
            URL: https://github.com/apache/ignite/pull/5781
             
             
               
             
            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.
             
            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ]
          ilyak Ilya Kasnacheev made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]

          Oleg Ignatenko thank you for contribution! I have merged it to master.

          ilyak Ilya Kasnacheev added a comment - Oleg Ignatenko thank you for contribution! I have merged it to master.

          Oleg Ignatenko,

          I reviewed the branch, it looks good to me. As we don't have any blockers according to TC Bot please proceed with merging it into a master branch.

          Thank you for this important contribution!

          sergey-chugunov Sergey Chugunov added a comment - Oleg Ignatenko , I reviewed the branch, it looks good to me. As we don't have any blockers according to TC Bot please proceed with merging it into a master branch. Thank you for this important contribution!
          ignitetcbot Ignite TC Bot added a comment -
          --> Run :: All (Nightly): No blockers found!

          TeamCity --> Run :: All (Nightly) Results

          ignitetcbot Ignite TC Bot added a comment - --> Run :: All (Nightly): No blockers found! TeamCity --> Run :: All (Nightly) Results
          oignatenko Oleg Ignatenko made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          oignatenko Oleg Ignatenko added a comment -

          note regarding possible blockers reported by TC bot above. Teamcity currently reports that both suites fail in master exactly the same way: Queries 1 in master / Queries (Binary Objects Simple Mapper) in master

          Vladimir Ozerov mentioned recently in chat that it is a known problem.

          As a side note, diffs for this PR show that changes made here have nothing to do with above test suites.

          oignatenko Oleg Ignatenko added a comment - note regarding possible blockers reported by TC bot above. Teamcity currently reports that both suites fail in master exactly the same way: Queries 1 in master / Queries (Binary Objects Simple Mapper) in master Vladimir Ozerov mentioned recently in chat that it is a known problem. As a side note, diffs for this PR show that changes made here have nothing to do with above test suites.
          ignitetcbot Ignite TC Bot added a comment -
          --> Run :: All (Nightly): Possible Blockers

          Queries 1 [tests 4

          • IgniteBinaryCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testSingleInnerFieldUpdate - 1,2% fails in last 413 master runs.
          • IgniteBinaryCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testTypeConversions - 1,2% fails in last 413 master runs.
          • IgniteBinaryCacheQueryTestSuite: IgniteCacheMergeSqlQuerySelfTest.testNestedFieldsHandling - 1,2% fails in last 413 master runs.

          Queries (Binary Objects Simple Mapper) [tests 4

          • IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheMergeSqlQuerySelfTest.testNestedFieldsHandling - 1,2% fails in last 412 master runs.
          • IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testSingleInnerFieldUpdate - 1,2% fails in last 412 master runs.
          • IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testTypeConversions - 1,2% fails in last 412 master runs.
          • IgniteBinarySimpleNameMapperCacheQueryTestSuite: IndexingCachePartitionLossPolicySelfTest.testReadWriteSafeWithBackups - 0,0% fails in last 412 master runs.

          TeamCity --> Run :: All (Nightly) Results

          ignitetcbot Ignite TC Bot added a comment - --> Run :: All (Nightly): Possible Blockers Queries 1 [tests 4 IgniteBinaryCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testSingleInnerFieldUpdate - 1,2% fails in last 413 master runs. IgniteBinaryCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testTypeConversions - 1,2% fails in last 413 master runs. IgniteBinaryCacheQueryTestSuite: IgniteCacheMergeSqlQuerySelfTest.testNestedFieldsHandling - 1,2% fails in last 413 master runs. Queries (Binary Objects Simple Mapper) [tests 4 IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheMergeSqlQuerySelfTest.testNestedFieldsHandling - 1,2% fails in last 412 master runs. IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testSingleInnerFieldUpdate - 1,2% fails in last 412 master runs. IgniteBinarySimpleNameMapperCacheQueryTestSuite: IgniteCacheUpdateSqlQuerySelfTest.testTypeConversions - 1,2% fails in last 412 master runs. IgniteBinarySimpleNameMapperCacheQueryTestSuite: IndexingCachePartitionLossPolicySelfTest.testReadWriteSafeWithBackups - 0,0% fails in last 412 master runs. TeamCity --> Run :: All (Nightly) Results
          oignatenko Oleg Ignatenko added a comment -

          in the course of review Sergey Chugunov proposed a way to make DynamicSuite code reusable instead of repeating the same boilerplate in 47 suite classes, I plan to integrate his improvement.

          oignatenko Oleg Ignatenko added a comment - in the course of review Sergey Chugunov proposed a way to make DynamicSuite code reusable instead of repeating the same boilerplate in 47 suite classes, I plan to integrate his improvement.
          oignatenko Oleg Ignatenko made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          githubbot ASF GitHub Bot made changes -
          Worklog Id 188889 [ 188889 ]
          Time Spent 10m [ 600 ] 20m [ 1200 ]
          githubbot ASF GitHub Bot logged work - 23/Jan/19 12:26
          • Time Spent:
            10m
             
            sergey-chugunov-1985 commented on pull request #5781: IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites
            URL: https://github.com/apache/ignite/pull/5781#discussion_r250173787
             
             

             ##########
             File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheReadThroughEvictionsVariationsSuite.java
             ##########
             @@ -17,26 +17,21 @@
             
             package org.apache.ignite.internal.processors.cache;
             
            -import junit.framework.TestSuite;
            +import java.util.List;
             import org.apache.ignite.configuration.IgniteConfiguration;
             import org.apache.ignite.internal.binary.BinaryMarshaller;
             import org.apache.ignite.lang.IgnitePredicate;
             import org.apache.ignite.testframework.configvariations.ConfigVariationsTestSuiteBuilder;
             import org.junit.runner.RunWith;
            -import org.junit.runners.AllTests;
            +import org.junit.runners.Suite;
            +import org.junit.runners.model.InitializationError;
             
            -/**
            - *
            - */
            -@RunWith(AllTests.class)
            +/** */
            +@RunWith(IgniteCacheReadThroughEvictionsVariationsSuite.DynamicSuite.class)
             public class IgniteCacheReadThroughEvictionsVariationsSuite {
             
             Review comment:
               It seems logical to move this test to the testsuites package where other suite classes reside.
             
            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.
             
            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ] This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ]
          oignatenko Oleg Ignatenko made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          ignitetcbot Ignite TC Bot added a comment -
          --> Run :: All (Nightly): No blockers found!

          TeamCity --> Run :: All (Nightly) Results

          ignitetcbot Ignite TC Bot added a comment - --> Run :: All (Nightly): No blockers found! TeamCity --> Run :: All (Nightly) Results
          oignatenko Oleg Ignatenko added a comment - - edited

          per discussion with reviewer (Eduard Shangareev) originally submitted solution has been deeply reworked to use javassist, somewhat similar to how it is done in IgniteExamplesMLTestSuite

          oignatenko Oleg Ignatenko added a comment - - edited per discussion with reviewer ( Eduard Shangareev ) originally submitted solution has been deeply reworked to use javassist, somewhat similar to how it is done in IgniteExamplesMLTestSuite
          oignatenko Oleg Ignatenko made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          oignatenko Oleg Ignatenko made changes -
          Fix Version/s 2.8 [ 12343972 ]
          ignitetcbot Ignite TC Bot added a comment -
          --> Run :: All (Nightly): No blockers found!

          TeamCity --> Run :: All (Nightly) Results

          ignitetcbot Ignite TC Bot added a comment - --> Run :: All (Nightly): No blockers found! TeamCity --> Run :: All (Nightly) Results
          oignatenko Oleg Ignatenko made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          ignitetcbot Ignite TC Bot added a comment -
          --> Run :: All: No blockers found!

          TeamCity --> Run :: All Results

          ignitetcbot Ignite TC Bot added a comment - --> Run :: All: No blockers found! TeamCity --> Run :: All Results
          githubbot ASF GitHub Bot made changes -
          Worklog Id 181751 [ 181751 ]
          Remaining Estimate 0h [ 0 ]
          Time Spent 10m [ 600 ]
          githubbot ASF GitHub Bot logged work - 07/Jan/19 13:26
          • Time Spent:
            10m
             
            oignatenko commented on pull request #5781: IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites
            URL: https://github.com/apache/ignite/pull/5781
             
             
               
             
            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.
             
            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5781 (Web Link)" [ 142015 ]
          oignatenko Oleg Ignatenko made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          oignatenko Oleg Ignatenko made changes -
          Assignee Oleg Ignatenko [ oignatenko ]
          agoncharuk Alexey Goncharuk made changes -
          Summary migrate from JUnit 3 to 4 config variations test suites Migrate from JUnit 3 to 4 config variations test suites
          oignatenko Oleg Ignatenko made changes -
          Link This issue is related to IGNITE-10739 [ IGNITE-10739 ]
          oignatenko Oleg Ignatenko made changes -
          Ignite Flags Docs Required [ 12560 ]
          oignatenko Oleg Ignatenko made changes -
          Field Original Value New Value
          Labels MakeTeamcityGreenAgain
          oignatenko Oleg Ignatenko created issue -

          People

            oignatenko Oleg Ignatenko
            oignatenko Oleg Ignatenko
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                Slack