[IGNITE-10762] Migrate test suites from Junit 3 to 4

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Done
• Affects Version/s: 2.8
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain technical_debt
• Assignee: Oleg Ignatenko
• Reporter: Ivan Pavlukhin
• Created: 20/Dec/18 15:52
• Updated: 24/Jan/19 20:22
• Resolved: 24/Jan/19 20:22

Description

It seems that @Ignore annotation is processed incorrectly when a test in Junit 4 style is included into Junit 3 test suite (wrapped into JUnit4TestAdapter). Actually such test is skipped silently when it is called during a suite execution. So, for full a blown usage of @Ignore test suites must be migrated to Junit 4 as well. Expected behavior here is reporting that a particular test method was ignored after tests execution. Ignored tests should be visible in CI.

Apparently such unexpected behavior of @Ignore can be caused by JUnit4TestAdapter as it explicitly filters test method marked with this annotation.

Issue Links

• is depended upon by: IGNITE-10208 Verify list of tests after migration to Junit 4 against some prior reference (follow-up to IGNITE-10177)
• is depended upon by: IGNITE-10951 migration from Junit 3 to 4 phase 2 (follow-up to IGNITE-10173)
• is related to: IGNITE-10173 Gradually move unit tests from Junit 3 to newer version
• relates to: IGNITE-10178 change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")

Sub-Tasks

• Migrate examples testsuites from Junit 3 to 4: Resolved
• Migrate test suites that are fixed lists of test classes from Junit 3 to 4: Resolved
• Migrate from JUnit 3 to 4 test suites of simple dynamic lists that use addTestIfNeeded API: Resolved
• Migrate from JUnit 3 to 4 config variations test suites: Resolved
• Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites: Resolved
• Migrate from JUnit 3 to 4 suites involving IgniteTestSuite: Resolved