[IGNITE-10629] Migration follow up: check for old style tests that could be slipped through in transition period

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 10/Dec/18 19:03
• Updated: 23/Jan/19 10:26
• Resolved: 23/Jan/19 10:23

Description

We need to account for risk that while tests are migrating some commits may by mistake slip in old style test cases - that will be ignored by JUnit 4.

In order to address possible issues of that kind, do the following a week or two after IGNITE-10177 is merged to master: run the IntelliJ inspection called "old style Junit test method in JUnit 4 class", review report and fix discovered problems if there are any.

For the reference, my version of IDE explains this inspection as follows:

Reports JUnit 3 style test methods which are located inside a class which does not extend the abstract JUnit 3 class TestCase and contains JUnit 4/JUnit 5 @Test annotated methods.

(note concerns mentioned in this ticket were originally raised at dev list: here)

---

Another part of this task is to find (and rework if there are still any) classes that still extend junit.framework.TestCase. These classes are technically legal but after vast majority have been migrated they became harmful from maintenance perspective, by forcing readers of their code learn details of obsolete framework version that lacks many important features. One particularly bad thing about such tests is that they deprive maintainers standard ways to suppress test execution using modern JUnit API of Ignore and Assume.

Issue Links

• depends upon: IGNITE-10177 cleanup Junit 3 from the project
• relates to: IGNITE-10208 Verify list of tests after migration to Junit 4 against some prior reference (follow-up to IGNITE-10177)
• links to: GitHub Pull Request #5879