Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-10173 Gradually move unit tests from Junit 3 to newer version
  3. IGNITE-10177

cleanup Junit 3 from the project

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8
    • None
    • None

    Description

      If needed, refer parent task for more details.

      1. remove Junit3-specific parts of API of GridAbstractTest and its subclasses
      2. remove dependencies from Junit 3 in Maven (if there are any)
      3. migrate tests that were missed at prior steps for various reasons:
        1. untangle design of IgnitePdsContinuousRestartTest and its subclass which currently conflict with Junit4 execution because of using constructors and make them properly use @Test annotation
        2. find out why WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync appears to start running slow / timing out after adding Junit 4 annotations (reproduced this on teamcity and locally as was discovered in IGNITE-10175)
        3. find out why IgniteTwitterStreamerTest runs fine under JUnit 3 but starts failing after move to JUnit 4
        4. IgniteCachePartitionedQuerySelfTest, IgniteCacheReplicatedQueryP2PDisabledSelfTest, ComputeUtilsTest, CacheBasedDatasetBuilderTest, CacheBasedDatasetTest, GridPartitionedCacheJtaLookupClassNameSelfTest, GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating these at IGNITE-10176)
        5. find out why tests in logging suite failed on teamcity (not locally) when setup method was annotated @Before
        6. note part of this work related to IgniteConfigVariationsAbstractTest is expected to be done separately per IGNITE-10739
      4. in tests suite classes, change extends TestSuite to either @RunWith(AllTests.class) or @Suite.SuiteClasses
      5. find and update all Junit3-specific code that extends TestCase
      6. execute junit related inspections of IDE and analyse results
      7. remove redundant references to JUnit4.class if there are any (like in @RunWith(JUnit4.class))
        per discussion with EdShangGG plan to to do this in a separate ticket for smoother merges - IGNITE-10758

      Side note if for some reason it turns out critically important to keep test suites names (by default Junit 4 will use suite class names instead), approach with custom description annotation described here can be used to address that.

      Attachments

        Issue Links

          depends upon

          Sub-task - The sub-task of the issue IGNITE-10175 migrate core module tests from Junit 3 to 4

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue IGNITE-10176 migrate non-core modules tests from Junit 3 to 4

          • Major - Major loss of function.
          • Resolved
          is depended upon by

          Sub-task - The sub-task of the issue IGNITE-10178 change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue IGNITE-10179 Change new tests root to use @BeforeClass and @AfterClass instead of isFirstTest() and isLastTest()

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue IGNITE-10180 Investigate migration from Junit 4 to 5

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue IGNITE-10629 Migration follow up: check for old style tests that could be slipped through in transition period

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue IGNITE-10758 remove from tests scaffolding annotations "@RunWith(JUnit4.class)" and their respective imports

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. IGNITE-10208 Verify list of tests after migration to Junit 4 against some prior reference (follow-up to IGNITE-10177)

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. IGNITE-10739 get rid of using JUnit 3 API in IgniteConfigVariationsAbstractTest

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #5615

          Web Link Upsource review

          Activity

            People

              oignatenko Oleg Ignatenko
              oignatenko Oleg Ignatenko
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: