[HTTPCLIENT-725] TSCCM code cleanup

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0 Alpha 3
• Component/s: HttpClient (classic)
• Assignee: Roland Weber
• Reporter: Roland Weber
• Created: 28/Dec/07 17:38
• Updated: 20/Sep/16 19:30
• Resolved: 07/Jan/08 09:22

Description

The ThreadSafeClientConnectionManager, or rather it's ConnPoolByRoute, needs plenty of cleanup.

• use long + TimeUnit for timeout intervals (Java 5 style)
• compute timeout end date once instead of remaining interval
• review which methods should acquire the pool lock,
  and which should expect the caller to have done that
• use factory methods to instantiate some of the helper objects