[HTTPCLIENT-1772] [OSGi] WeakList needs to support "clear" method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.2, 5.0 Alpha1
• Fix Version/s: 4.5.3, 5.0 Alpha2
• Component/s: HttpClient (classic)
• Assignee: Julian Sedding
• Reporter: Julian Sedding
• Created: 27/Sep/16 10:08
• Updated: 30/Sep/16 14:25
• Resolved: 30/Sep/16 14:10

Description

The WeakList implementation introduced in HTTPCLIENT-1749 does not currently implement the close() method.

However, HttpProxyConfigurationActivator calls this method when the OSGi bundle is stopped, leading to an exception being thrown.

org.osgi.framework.BundleException: Activator stop error in bundle org.apache.httpcomponents.httpclient [122].
        at org.apache.felix.framework.Felix.stopBundle(Felix.java:2663)
        at org.apache.felix.framework.Felix.updateBundle(Felix.java:2341)
        at org.apache.felix.framework.BundleImpl.update(BundleImpl.java:995)
        at org.apache.felix.webconsole.internal.core.UpdateHelper.doRun(UpdateHelper.java:60)
        at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.doRun(BaseUpdateInstallHelper.java:93)
        at org.apache.felix.webconsole.internal.core.UpdateHelper.doRun(UpdateHelper.java:70)
        at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:123)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.UnsupportedOperationException: null
        at java.util.AbstractList.remove(AbstractList.java:161)
        at java.util.AbstractList$Itr.remove(AbstractList.java:374)
        at java.util.AbstractList.removeRange(AbstractList.java:571)
        at java.util.AbstractList.clear(AbstractList.java:234)
        at org.apache.http.osgi.impl.HttpProxyConfigurationActivator.stop(HttpProxyConfigurationActivator.java:140)
        at org.apache.felix.framework.util.SecureAction.stopActivator(SecureAction.java:719)
        at org.apache.felix.framework.Felix.stopBundle(Felix.java:2607)
        ... 7 common frames omitted