[HTTPCLIENT-1749] Memory Leak in OSGi support

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4.1, 4.5.2
• Fix Version/s: 4.5.3
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Justin Edelson
• Created: 08/Jun/16 18:22
• Updated: 24/Jan/18 10:17
• Resolved: 11/Jun/16 15:56

Description

There is a memory leak in the HTTP Client OSGi support whereby the HttpProxyConfigurationActivator holds on to references to created HttpClient instances for the entire life of the httpclient-osgi bundle, which may be (and probably is in many cases) longer than the lifespan of individual HttpClient instances.

The clients are added here: http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpclient-osgi/4.4.1/org/apache/http/osgi/impl/OSGiHttpClientBuilder.java#58

and not removed until http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpclient-osgi/4.4.1/org/apache/http/osgi/impl/HttpProxyConfigurationActivator.java#115

This can be relatively easily fixed by using weak references. In addition, access to this collection needs to be synchronized because the additions may come from multiple threads.

Issue Links

• is duplicated by: HTTPCLIENT-1899 Memory leak in OSGi support