[HTTPCLIENT-1703] GET request should support body

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.1
• Fix Version/s: 5.0 Alpha1
• Component/s: Fluent HC
• Assignee: Unassigned
• Reporter: Konstantin Ignatyev
• Created: 13/Dec/15 19:54
• Updated: 04/May/17 09:49
• Resolved: 23/Feb/16 20:35

Description

I have discovered that fluent client does not allow BODY for a get request
java.lang.IllegalStateException: GET request cannot enclose an entity
at org.apache.http.client.fluent.Request.body(Request.java:348)
at org.apache.http.client.fluent.Request.bodyString(Request.java:375)
at kgi.mcytravel.wsite.services.FullTextSearchService.fullTextSearch(FullTextSearchService.scala:72)

Which is not correct, spec does not prohibit GET request from having a body. It seems a bit unconventional but makes perfect sense considering complex search requests use case. And it is utilized by ElasticSearch for example

https://www.elastic.co/guide/en/elasticsearch/reference/current/search.html

curl -XGET 'http://localhost:9200/twitter/tweet/_search?routing=kimchy' -d '{
"query": {
"bool" : {
"must" : {
"query_string" :

{ "query" : "some query string here" }

},
"filter" : {
"term" :

{ "user" : "kimchy" }

}
}
}
}
'