[HTTPCLIENT-1671] RequestDefaultHeaders should only be set if the header hasn't already been set

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0 Alpha1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Steve Davids
• Created: 28/Jul/15 16:22
• Updated: 04/May/17 09:49
• Resolved: 10/Aug/15 19:46

Description

The name implies that default header values will be applied to the request which generally means that if the request doesn't specify a header value then the default is applied. For example:

defaultHeaderValue = ["Accept": "application/json"]

httpClient.execute(new HttpGet(url)); //header should be application/json

HttpGet get = new HttpGet(url);
get.setHeader("Accept", "application/xml");
httpClient.execute(get); //header should be application/xml, *not* application/xml, application/json

A simple fix would be to add the following code snippet:

if(!request.containsHeader(defHeader.getName)) {
    request.addHeader(defHeader);
}