[HTTPCLIENT-1650] Fluent Executor doesn't inherit auth scheme and creds provider of HttpClient instance

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.4.1
• Fix Version/s: 5.0 Alpha1
• Component/s: Fluent HC
• Labels: flexibility
• Environment: Windows Server 2008
• Flags: Patch
• Assignee: Unassigned
• Reporter: Alexandre
• Created: 22/May/15 20:37
• Updated: 04/May/17 09:49
• Resolved: 26/May/15 19:05

Description

When instantiating an Executor from an existing HttpClient instance, the Executor doesn't inherit the credentials provider.

Executor(final HttpClient httpclient)

{ super(); this.httpclient = httpclient; this.credentialsProvider = new BasicCredentialsProvider(); this.authCache = new BasicAuthCache(); }

For instance, to perform an HTTP request using the Windows integrated authentication, the following will correctly authenticate:

WinHttpClients.createDefault().execute(new HttpGet(...));

But this will not:

Executor.newInstance(defaultWinHttpClient).execute(Request.Get(...))

I think that this behavior is very counter-intuitive and limiting at the same time. When an Executor is instantiated from an HttpClient instance, all configurations from that instance should be taken in account.