[HTTPCLIENT-1495] Finalizer in PoolingHttpClientConnectionManager should not log "shutdown" messages if already shutdown normally

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3.1
• Fix Version/s: 4.3.4, 4.4 Alpha1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Christopher Brown
• Created: 14/Apr/14 14:40
• Updated: 04/May/17 09:49
• Resolved: 16/Apr/14 11:54

Description

Despite shutting down the CloseableHttpClient instance using "close()", which in turn calls shutdown() on the PoolingHttpClientConnectionManager, messages are still logged such as the following in all cases after a JVM garbage collection:

[Finalizer] DEBUG o.a.h.i.c.PoolingHttpClientConnectionManager - Connection manager is shutting down

The finalizer thread always calls "shutdown", which always logs the "shutdown" messages. This led me to believe (when tracking memory leaks) that there was a problem in my usage of HTTP client, when in fact the message was just misleading (everything was fine).

It would be preferable, perhaps via a volatile boolean instance field on the connection manager, to suppress the shutdown messages (and maybe even suppress redundant resource cleanup attempts). This would help users of the library to concentrate on other issues.

Thanks.