[HTTPCLIENT-1434] TrustSelfSignedStrategy should be a singleton

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.3.1
• Fix Version/s: 4.4 Alpha1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Sebastiano Vigna
• Created: 12/Nov/13 09:55
• Updated: 04/May/17 09:49
• Resolved: 04/Jun/14 12:22

Description

TrustSelfSignedStrategy should be a singleton, as it happens for several other strategies in HTTP Client. For example,

public class TrustSelfSignedStrategy implements TrustStrategy {

public static final TrustSelfSignedStrategy INSTANCE = new TrustSelfSignedStrategy();

private TrustSelfSignedStrategy() {}

public boolean isTrusted(
final X509Certificate[] chain, final String authType) throws CertificateException

{ return chain.length == 1; }

}

Incidentally, I noted that other strategies (e.g., NoConnectionReuseStrategy) have a public constructor, which violates the Singleton design pattern.