Hive
  1. Hive
  2. HIVE-6217

Refactor Beeline's JDBC connection to use property map instead of long url

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.13.0
    • Component/s: CLI, JDBC
    • Labels:
      None

      Description

      To make a connection to HiverServer2, currently Beeline constructs a long url that contains hiveconf and hivevariables. At JDBC driver side, it parses the url into individual maps. Constructing and decomposing the url is complicated and unnecessary, using a different method from JDBC DriverManager that takes a property map makes the logic simpler, especially when hiveconf and hivevar variables can also come from Beeline command line in addition to those in connection url.

      This is identified in and required by HIVE-6173.

      1. HIVE-6217.patch
        3 kB
        Xuefu Zhang
      2. HIVE-6217.1.patch
        4 kB
        Xuefu Zhang
      3. HIVE-6217.1.patch
        4 kB
        Xuefu Zhang
      4. HIVE-6217.1.patch
        4 kB
        Prasad Mujumdar

        Issue Links

          Activity

          Hide
          Xuefu Zhang added a comment -

          Patch committed to trunk. Thanks to Prasad for the review.

          Show
          Xuefu Zhang added a comment - Patch committed to trunk. Thanks to Prasad for the review.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625939/HIVE-6217.1.patch

          SUCCESS: +1 4972 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1111/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1111/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12625939

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625939/HIVE-6217.1.patch SUCCESS: +1 4972 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1111/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1111/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12625939
          Hide
          Prasad Mujumdar added a comment -

          Attaching the same patch again to for another test run.

          Show
          Prasad Mujumdar added a comment - Attaching the same patch again to for another test run.
          Hide
          Prasad Mujumdar added a comment -

          +1

          I don't think the test failures are due to this patch, will reattach the patch to kick off another run just to make sure.

          Show
          Prasad Mujumdar added a comment - +1 I don't think the test failures are due to this patch, will reattach the patch to kick off another run just to make sure.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12624892/HIVE-6217.1.patch

          ERROR: -1 due to 7 failed/errored test(s), 4949 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_filter
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_groupby
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_join
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_part
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_select
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_table
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_union
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1002/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1002/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 7 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12624892

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624892/HIVE-6217.1.patch ERROR: -1 due to 7 failed/errored test(s), 4949 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_filter org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_groupby org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_join org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_select org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_table org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_union Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1002/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1002/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed This message is automatically generated. ATTACHMENT ID: 12624892
          Hide
          Vaibhav Gumashta added a comment -

          +1 (non-binding). Looks good to me.

          Show
          Vaibhav Gumashta added a comment - +1 (non-binding). Looks good to me.
          Hide
          Xuefu Zhang added a comment -

          RB diff is updated. Thanks to Vaibhav for pointing it out.

          Show
          Xuefu Zhang added a comment - RB diff is updated. Thanks to Vaibhav for pointing it out.
          Hide
          Vaibhav Gumashta added a comment -

          Xuefu Zhang Can you also update the rb link?

          Thanks for the patch!

          Show
          Vaibhav Gumashta added a comment - Xuefu Zhang Can you also update the rb link? Thanks for the patch!
          Hide
          Xuefu Zhang added a comment -

          Patch #1 updated to accommodate review comments on review board.

          Show
          Xuefu Zhang added a comment - Patch #1 updated to accommodate review comments on review board.
          Hide
          Xuefu Zhang added a comment -
          Show
          Xuefu Zhang added a comment - RB: https://reviews.apache.org/r/17169/
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12623697/HIVE-6217.patch

          SUCCESS: +1 4940 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/948/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/948/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12623697

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12623697/HIVE-6217.patch SUCCESS: +1 4940 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/948/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/948/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12623697

            People

            • Assignee:
              Xuefu Zhang
              Reporter:
              Xuefu Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development