[HIVE-6051] Create DecimalColumnVector and a representative VectorExpression for decimal - ASF JIRA

Details

Type: Sub-task
Status: Resolved
Priority: Major
Resolution: Implemented
Affects Version/s: 0.13.0
Fix Version/s: 0.13.0
Component/s: None
Labels:
None

Description

Create a DecimalColumnVector to use as a basis for vectorized decimal operations. Include a representative VectorExpression on decimal (e.g. column-column addition) to demonstrate it's use.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

HIVE-6051.02.patch

03/Jan/14 18:51

15 kB

Eric Hanson
HIVE-6051.01.patch

17/Dec/13 23:31

16 kB

Eric Hanson

Issue Links

depends upon

HIVE-6017 Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive

Resolved

Is contained by

HIVE-5762 Implement vectorized support for the DECIMAL data type

In Progress

is depended upon by

HIVE-6067 Implement vectorized decimal comparison filters

Resolved

HIVE-6124 Support basic Decimal arithmetic in vector mode (+, -, *)

Resolved

HIVE-6139 Implement vectorized decimal division and modulo

Resolved

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eric Hanson added a comment - 03/Jan/14 00:14

Review at https://reviews.apache.org/r/16584/

Show

Eric Hanson added a comment - 03/Jan/14 00:14 Review at https://reviews.apache.org/r/16584/

Hide

Permalink

Hive QA added a comment - 03/Jan/14 15:15

Overall: -1 no tests executed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12619194/HIVE-6051.01.patch

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/794/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/794/console

Messages:

Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-794/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted 'shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java'
Reverted 'hbase-handler/src/test/results/negative/cascade_dbdrop.q.out'
Reverted 'hbase-handler/src/test/results/positive/hbase_bulk.m.out'
Reverted 'hbase-handler/src/test/queries/positive/hbase_bulk.m'
++ awk '{print $2}'
++ egrep -v '^X|^Performing status on external'
++ svn status --no-ignore
+ rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/storage-handlers/hbase/target hcatalog/server-extensions/target hcatalog/core/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hcatalog/hcatalog-pig-adapter/target hwi/target common/target common/src/gen contrib/target service/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target
+ svn update

Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1555121.

At revision 1555121.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'

This message is automatically generated.

ATTACHMENT ID: 12619194

Show

Hive QA added a comment - 03/Jan/14 15:15 Overall : -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12619194/HIVE-6051.01.patch Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/794/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/794/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]] + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-794/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java' Reverted 'hbase-handler/src/test/results/negative/cascade_dbdrop.q.out' Reverted 'hbase-handler/src/test/results/positive/hbase_bulk.m.out' Reverted 'hbase-handler/src/test/queries/positive/hbase_bulk.m' ++ awk '{print $2}' ++ egrep -v '^X|^Performing status on external' ++ svn status --no-ignore + rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/storage-handlers/hbase/target hcatalog/server-extensions/target hcatalog/core/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hcatalog/hcatalog-pig-adapter/target hwi/target common/target common/src/gen contrib/target service/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target + svn update Fetching external item into 'hcatalog/src/test/e2e/harness' External at revision 1555121. At revision 1555121. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' This message is automatically generated. ATTACHMENT ID: 12619194

Hide

Permalink

Eric Hanson added a comment - 03/Jan/14 18:52

Fixed minor formatting issue to allow patch to apply to trunk.

Show

Eric Hanson added a comment - 03/Jan/14 18:52 Fixed minor formatting issue to allow patch to apply to trunk.

Hide

Permalink

Hive QA added a comment - 04/Jan/14 03:43

Overall: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12621359/HIVE-6051.02.patch

SUCCESS: +1 4876 tests passed

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/803/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/803/console

Messages:

Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase

This message is automatically generated.

ATTACHMENT ID: 12621359

Show

Hive QA added a comment - 04/Jan/14 03:43 Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12621359/HIVE-6051.02.patch SUCCESS: +1 4876 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/803/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/803/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12621359

Hide

Permalink

Jitendra Nath Pandey added a comment - 07/Jan/14 01:48

I suppose DecimalColAddDecimalColumn will be a generated code from template. Will it be deleted when the template is added? I am fine with that, however.

+1 lgtm.

Show

Jitendra Nath Pandey added a comment - 07/Jan/14 01:48 I suppose DecimalColAddDecimalColumn will be a generated code from template. Will it be deleted when the template is added? I am fine with that, however. +1 lgtm.

Hide

Permalink

Eric Hanson added a comment - 07/Jan/14 17:37

I'll remove DecimalColAddDecimalColumn later when an equivalent of it is generated from a template.

Show

Eric Hanson added a comment - 07/Jan/14 17:37 I'll remove DecimalColAddDecimalColumn later when an equivalent of it is generated from a template.

Hide

Permalink

Eric Hanson added a comment - 08/Jan/14 18:17

Committed to trunk

Show

Eric Hanson added a comment - 08/Jan/14 18:17 Committed to trunk

People

Assignee:

Eric Hanson

Reporter:

Eric Hanson

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

17/Dec/13 23:27

Updated:

08/Jan/14 18:17

Resolved:

08/Jan/14 18:17

Development

Agile

View on Board