Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Implemented
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      Support column-scalar, scalar-column, and column-column versions for division and modulo. Include unit tests.

      1. HIVE-6139.01.patch
        6 kB
        Eric Hanson
      2. HIVE-6139.02.patch
        17 kB
        Eric Hanson
      3. HIVE-6139.07.patch
        52 kB
        Eric Hanson
      4. HIVE-6139.07.patch
        52 kB
        Eric Hanson
      5. HIVE-6139.08.patch
        50 kB
        Eric Hanson
      6. HIVE-6139.09.patch
        50 kB
        Eric Hanson
      7. HIVE-6139.10.patch
        54 kB
        Eric Hanson

        Issue Links

          Activity

          Hide
          Eric Hanson added a comment -

          Parking unfinished patch (new template) here.

          Show
          Eric Hanson added a comment - Parking unfinished patch (new template) here.
          Hide
          Eric Hanson added a comment -

          Updating unfinished patch. Works for Col-Scalar divide and modulo, with tests.

          Show
          Eric Hanson added a comment - Updating unfinished patch. Works for Col-Scalar divide and modulo, with tests.
          Hide
          Eric Hanson added a comment -
          Show
          Eric Hanson added a comment - Code review at https://reviews.apache.org/r/17000/
          Hide
          Eric Hanson added a comment -

          Uploading patch again to try to kick off automated tests, which didn't run last time.

          Show
          Eric Hanson added a comment - Uploading patch again to try to kick off automated tests, which didn't run last time.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12623966/HIVE-6139.07.patch

          ERROR: -1 due to 3 failed/errored test(s), 4948 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
          org.apache.hcatalog.api.TestHCatClient.testBasicDDLCommands
          org.apache.hcatalog.listener.TestNotificationListener.testAMQListener
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/963/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/963/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 3 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12623966

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12623966/HIVE-6139.07.patch ERROR: -1 due to 3 failed/errored test(s), 4948 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers org.apache.hcatalog.api.TestHCatClient.testBasicDDLCommands org.apache.hcatalog.listener.TestNotificationListener.testAMQListener Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/963/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/963/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed This message is automatically generated. ATTACHMENT ID: 12623966
          Hide
          Eric Hanson added a comment -

          I'll redo this patch to accommodate changes to Decimal128 divide

          Show
          Eric Hanson added a comment - I'll redo this patch to accommodate changes to Decimal128 divide
          Hide
          Eric Hanson added a comment -

          Fixed to match new interface for Decimal128.divide and Decimal128.modulo (without scratch argument).

          Show
          Eric Hanson added a comment - Fixed to match new interface for Decimal128.divide and Decimal128.modulo (without scratch argument).
          Hide
          Eric Hanson added a comment -

          Re-submitted patch to start unit tests

          Show
          Eric Hanson added a comment - Re-submitted patch to start unit tests
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12624866/HIVE-6139.08.patch

          ERROR: -1 due to 6 failed/errored test(s), 4966 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_reducers_power_two
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative
          org.apache.hcatalog.hbase.TestHBaseHCatStorageHandler.testTableCreateDrop
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1047/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1047/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 6 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12624866

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624866/HIVE-6139.08.patch ERROR: -1 due to 6 failed/errored test(s), 4966 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_reducers_power_two org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative org.apache.hcatalog.hbase.TestHBaseHCatStorageHandler.testTableCreateDrop Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1047/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1047/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed This message is automatically generated. ATTACHMENT ID: 12624866
          Hide
          Eric Hanson added a comment -

          Re-based on current trunk. No significant changes.

          Show
          Eric Hanson added a comment - Re-based on current trunk. No significant changes.
          Hide
          Jitendra Nath Pandey added a comment -

          Posted comments on review board.

          Show
          Jitendra Nath Pandey added a comment - Posted comments on review board.
          Hide
          Eric Hanson added a comment -

          Updated based on Jitendra's code review comments.

          Show
          Eric Hanson added a comment - Updated based on Jitendra's code review comments.
          Hide
          Jitendra Nath Pandey added a comment -

          +1

          Show
          Jitendra Nath Pandey added a comment - +1
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625913/HIVE-6139.10.patch

          SUCCESS: +1 4977 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1107/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1107/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12625913

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625913/HIVE-6139.10.patch SUCCESS: +1 4977 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1107/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1107/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12625913
          Hide
          Eric Hanson added a comment -

          Committed to trunk

          Show
          Eric Hanson added a comment - Committed to trunk

            People

            • Assignee:
              Eric Hanson
              Reporter:
              Eric Hanson
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development