Hive
  1. Hive
  2. HIVE-5786

Remove HadoopShims methods that were needed for pre-Hadoop 0.20

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Shims
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are several methods in HadoopShims that can be removed since we are only supporting 0.20+.

        Issue Links

          Activity

          Jason Dere created issue -
          Hide
          Jason Dere added a comment -

          Looks like the following shims methods can be removed from HadoopShims:

          usesJobShell
          isJobPreparing
          fileSystemDeleteOnExit
          inputFormatValidateInput
          setTmpFiles
          getAccessTime
          compareText
          setFloatConf
          getTaskJobIDs

          Show
          Jason Dere added a comment - Looks like the following shims methods can be removed from HadoopShims: usesJobShell isJobPreparing fileSystemDeleteOnExit inputFormatValidateInput setTmpFiles getAccessTime compareText setFloatConf getTaskJobIDs
          Hide
          Jason Dere added a comment -

          patch v1.

          Show
          Jason Dere added a comment - patch v1.
          Jason Dere made changes -
          Field Original Value New Value
          Attachment HIVE-5786.1.patch [ 12612904 ]
          Hide
          Jason Dere added a comment -
          Show
          Jason Dere added a comment - RB at https://reviews.apache.org/r/15373/
          Jason Dere made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Ashutosh Chauhan added a comment -

          +1 Thanks for clean-up. Really appreciate your effort for cleaning up dead code.

          Show
          Ashutosh Chauhan added a comment - +1 Thanks for clean-up. Really appreciate your effort for cleaning up dead code.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12612904/HIVE-5786.1.patch

          SUCCESS: +1 4598 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/225/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/225/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12612904

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12612904/HIVE-5786.1.patch SUCCESS: +1 4598 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/225/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/225/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12612904
          Hide
          Carl Steinbach added a comment -

          Committed to trunk. Thanks Jason!

          Show
          Carl Steinbach added a comment - Committed to trunk. Thanks Jason!
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Navis made changes -
          Link This issue is duplicated by HIVE-5342 [ HIVE-5342 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          37m 20s 1 Jason Dere 08/Nov/13 22:33
          Patch Available Patch Available Resolved Resolved
          10h 26m 1 Carl Steinbach 09/Nov/13 08:59

            People

            • Assignee:
              Jason Dere
              Reporter:
              Jason Dere
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development