Hive
  1. Hive
  2. HIVE-5342

Remove pre hadoop-0.20.0 related codes

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Shims
    • Labels:
      None

      Description

      Recently, we discussed not supporting hadoop-0.20.0. If it would be done like that or not, 0.17 related codes would be removed before that.

      1. D13047.1.patch
        320 kB
        Phabricator

        Issue Links

          Activity

          Hide
          Phabricator added a comment -

          navis has abandoned the revision "HIVE-5342 [jira] Remove pre hadoop-0.20.0 related codes".

          REVISION DETAIL
          https://reviews.facebook.net/D13047

          To: JIRA, navis

          Show
          Phabricator added a comment - navis has abandoned the revision " HIVE-5342 [jira] Remove pre hadoop-0.20.0 related codes". REVISION DETAIL https://reviews.facebook.net/D13047 To: JIRA, navis
          Hide
          Navis added a comment -

          Seemed mostly fixed in HIVE-4518 and HIVE-5786. Replacing serde2.io.*Writable seemed to be a huge work and has not much meaning. So closing this as duplicate.

          Show
          Navis added a comment - Seemed mostly fixed in HIVE-4518 and HIVE-5786 . Replacing serde2.io.*Writable seemed to be a huge work and has not much meaning. So closing this as duplicate.
          Hide
          Navis added a comment -

          Removing counter in Operator is the first step. There would be following works related to this, something like,

          1. replace serde2.io.*Writable with hadoop.io.*Writable
          2. remove shims for comparing Text
          3. possibly removing ByteArrayRef in Lazy<Non-Primitives>
          4. etc.

          I'll check the HIVE-4518, but it seemed a little intrusive at first look.

          Show
          Navis added a comment - Removing counter in Operator is the first step. There would be following works related to this, something like, 1. replace serde2.io.*Writable with hadoop.io.*Writable 2. remove shims for comparing Text 3. possibly removing ByteArrayRef in Lazy<Non-Primitives> 4. etc. I'll check the HIVE-4518 , but it seemed a little intrusive at first look.
          Hide
          Ashutosh Chauhan added a comment -

          Dupe of HIVE-4518 ? Navis You may want to review patch on HIVE-4518 which seems to be more comprehensive than this one.

          Show
          Ashutosh Chauhan added a comment - Dupe of HIVE-4518 ? Navis You may want to review patch on HIVE-4518 which seems to be more comprehensive than this one.
          Hide
          Phabricator added a comment -

          navis requested code review of "HIVE-5342 [jira] Remove pre hadoop-0.20.0 related codes".

          Reviewers: JIRA

          HIVE-5342 Remove pre hadoop-0.20.0 related codes

          Recently, we discussed not supporting hadoop-0.20.0. If it would be done like that or not, 0.17 related codes would be removed before that.

          TEST PLAN
          EMPTY

          REVISION DETAIL
          https://reviews.facebook.net/D13047

          AFFECTED FILES
          ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java
          ql/src/test/results/compiler/plan/case_sensitivity.q.xml
          ql/src/test/results/compiler/plan/cast1.q.xml
          ql/src/test/results/compiler/plan/groupby1.q.xml
          ql/src/test/results/compiler/plan/groupby2.q.xml
          ql/src/test/results/compiler/plan/groupby3.q.xml
          ql/src/test/results/compiler/plan/groupby4.q.xml
          ql/src/test/results/compiler/plan/groupby5.q.xml
          ql/src/test/results/compiler/plan/groupby6.q.xml
          ql/src/test/results/compiler/plan/input1.q.xml
          ql/src/test/results/compiler/plan/input2.q.xml
          ql/src/test/results/compiler/plan/input20.q.xml
          ql/src/test/results/compiler/plan/input3.q.xml
          ql/src/test/results/compiler/plan/input4.q.xml
          ql/src/test/results/compiler/plan/input5.q.xml
          ql/src/test/results/compiler/plan/input6.q.xml
          ql/src/test/results/compiler/plan/input7.q.xml
          ql/src/test/results/compiler/plan/input8.q.xml
          ql/src/test/results/compiler/plan/input9.q.xml
          ql/src/test/results/compiler/plan/input_part1.q.xml
          ql/src/test/results/compiler/plan/input_testsequencefile.q.xml
          ql/src/test/results/compiler/plan/input_testxpath.q.xml
          ql/src/test/results/compiler/plan/input_testxpath2.q.xml
          ql/src/test/results/compiler/plan/join1.q.xml
          ql/src/test/results/compiler/plan/join2.q.xml
          ql/src/test/results/compiler/plan/join3.q.xml
          ql/src/test/results/compiler/plan/join4.q.xml
          ql/src/test/results/compiler/plan/join5.q.xml
          ql/src/test/results/compiler/plan/join6.q.xml
          ql/src/test/results/compiler/plan/join7.q.xml
          ql/src/test/results/compiler/plan/join8.q.xml
          ql/src/test/results/compiler/plan/sample1.q.xml
          ql/src/test/results/compiler/plan/sample2.q.xml
          ql/src/test/results/compiler/plan/sample3.q.xml
          ql/src/test/results/compiler/plan/sample4.q.xml
          ql/src/test/results/compiler/plan/sample5.q.xml
          ql/src/test/results/compiler/plan/sample6.q.xml
          ql/src/test/results/compiler/plan/sample7.q.xml
          ql/src/test/results/compiler/plan/subq.q.xml
          ql/src/test/results/compiler/plan/udf1.q.xml
          ql/src/test/results/compiler/plan/udf4.q.xml
          ql/src/test/results/compiler/plan/udf6.q.xml
          ql/src/test/results/compiler/plan/udf_case.q.xml
          ql/src/test/results/compiler/plan/udf_when.q.xml
          ql/src/test/results/compiler/plan/union.q.xml

          MANAGE HERALD RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/37887/

          To: JIRA, navis

          Show
          Phabricator added a comment - navis requested code review of " HIVE-5342 [jira] Remove pre hadoop-0.20.0 related codes". Reviewers: JIRA HIVE-5342 Remove pre hadoop-0.20.0 related codes Recently, we discussed not supporting hadoop-0.20.0. If it would be done like that or not, 0.17 related codes would be removed before that. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D13047 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java ql/src/test/results/compiler/plan/case_sensitivity.q.xml ql/src/test/results/compiler/plan/cast1.q.xml ql/src/test/results/compiler/plan/groupby1.q.xml ql/src/test/results/compiler/plan/groupby2.q.xml ql/src/test/results/compiler/plan/groupby3.q.xml ql/src/test/results/compiler/plan/groupby4.q.xml ql/src/test/results/compiler/plan/groupby5.q.xml ql/src/test/results/compiler/plan/groupby6.q.xml ql/src/test/results/compiler/plan/input1.q.xml ql/src/test/results/compiler/plan/input2.q.xml ql/src/test/results/compiler/plan/input20.q.xml ql/src/test/results/compiler/plan/input3.q.xml ql/src/test/results/compiler/plan/input4.q.xml ql/src/test/results/compiler/plan/input5.q.xml ql/src/test/results/compiler/plan/input6.q.xml ql/src/test/results/compiler/plan/input7.q.xml ql/src/test/results/compiler/plan/input8.q.xml ql/src/test/results/compiler/plan/input9.q.xml ql/src/test/results/compiler/plan/input_part1.q.xml ql/src/test/results/compiler/plan/input_testsequencefile.q.xml ql/src/test/results/compiler/plan/input_testxpath.q.xml ql/src/test/results/compiler/plan/input_testxpath2.q.xml ql/src/test/results/compiler/plan/join1.q.xml ql/src/test/results/compiler/plan/join2.q.xml ql/src/test/results/compiler/plan/join3.q.xml ql/src/test/results/compiler/plan/join4.q.xml ql/src/test/results/compiler/plan/join5.q.xml ql/src/test/results/compiler/plan/join6.q.xml ql/src/test/results/compiler/plan/join7.q.xml ql/src/test/results/compiler/plan/join8.q.xml ql/src/test/results/compiler/plan/sample1.q.xml ql/src/test/results/compiler/plan/sample2.q.xml ql/src/test/results/compiler/plan/sample3.q.xml ql/src/test/results/compiler/plan/sample4.q.xml ql/src/test/results/compiler/plan/sample5.q.xml ql/src/test/results/compiler/plan/sample6.q.xml ql/src/test/results/compiler/plan/sample7.q.xml ql/src/test/results/compiler/plan/subq.q.xml ql/src/test/results/compiler/plan/udf1.q.xml ql/src/test/results/compiler/plan/udf4.q.xml ql/src/test/results/compiler/plan/udf6.q.xml ql/src/test/results/compiler/plan/udf_case.q.xml ql/src/test/results/compiler/plan/udf_when.q.xml ql/src/test/results/compiler/plan/union.q.xml MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/37887/ To: JIRA, navis
          Hide
          Navis added a comment -

          Removed dummy counters in Operator.

          Show
          Navis added a comment - Removed dummy counters in Operator.

            People

            • Assignee:
              Navis
              Reporter:
              Navis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development