Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-5206

Support parameterized primitive types

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: Types
    • Labels:
      None

      Description

      Support for parameterized types is needed for char/varchar/decimal support. This adds a type parameters value to the PrimitiveTypeEntry/PrimitiveTypeInfo/PrimitiveObjectInspector objects.

      NO PRECOMMIT TESTS - dependent on HIVE-5203/HIVE-5204

      1. HIVE-5206.v12.1.patch
        77 kB
        Jason Dere
      2. HIVE-5206.4.patch
        77 kB
        Jason Dere
      3. HIVE-5206.3.patch
        77 kB
        Jason Dere
      4. HIVE-5206.2.patch
        74 kB
        Jason Dere
      5. HIVE-5206.D12693.1.patch
        70 kB
        Phabricator
      6. HIVE-5206.1.patch
        74 kB
        Jason Dere

        Issue Links

          Activity

          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          ashutoshc Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
          Hide
          thejas Thejas M Nair added a comment -

          Patch committed to 0.12 branch

          Show
          thejas Thejas M Nair added a comment - Patch committed to 0.12 branch
          Hide
          jdere Jason Dere added a comment -

          attaching HIVE-5206.v12.1.patch, for use in 0.12 branch

          Show
          jdere Jason Dere added a comment - attaching HIVE-5206 .v12.1.patch, for use in 0.12 branch
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop1-ptest #164 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/164/)
          HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715)

          • /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop1-ptest #164 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/164/ ) HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715 ) /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2-ptest #97 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/97/)
          HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715)

          • /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #97 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/97/ ) HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715 ) /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hive-trunk-hadoop2 #426 (See https://builds.apache.org/job/Hive-trunk-hadoop2/426/)
          HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715)

          • /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hive-trunk-hadoop2 #426 (See https://builds.apache.org/job/Hive-trunk-hadoop2/426/ ) HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715 ) /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hive-trunk-h0.21 #2328 (See https://builds.apache.org/job/Hive-trunk-h0.21/2328/)
          HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715)

          • /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hive-trunk-h0.21 #2328 (See https://builds.apache.org/job/Hive-trunk-h0.21/2328/ ) HIVE-5206 : Support parameterized primitive types (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1522715 ) /hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Jason!

          Show
          ashutoshc Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Jason!
          Hide
          jdere Jason Dere added a comment -

          patch 4 - rebasing with trunk

          Show
          jdere Jason Dere added a comment - patch 4 - rebasing with trunk
          Hide
          jdere Jason Dere added a comment -

          Looks like I need to rebase this patch again due to HIVE-5263

          Show
          jdere Jason Dere added a comment - Looks like I need to rebase this patch again due to HIVE-5263
          Hide
          jdere Jason Dere added a comment -

          Ran unit tests - TestZooKeeperTokenStore, TestJdbcDriver2 failed, they passed when I ran them again.

          Tests Failures Errors Skipped Success rate Time
          2995 1 1 9 99.93% 33750.905

          Show
          jdere Jason Dere added a comment - Ran unit tests - TestZooKeeperTokenStore, TestJdbcDriver2 failed, they passed when I ran them again. Tests Failures Errors Skipped Success rate Time 2995 1 1 9 99.93% 33750.905
          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          +1

          Show
          ashutoshc Ashutosh Chauhan added a comment - +1
          Hide
          jdere Jason Dere added a comment -

          new patch (3) - changes per review from ashutosh:

          • primitive TypeEntry/TypeInfo/ObjInspector all implement PrimitiveTypeSoec interface, use in object inspector factory
          • GenericUDFBridge/Macro should be allowed to use SettableUDF
          • moved a few files/methods
          Show
          jdere Jason Dere added a comment - new patch (3) - changes per review from ashutosh: primitive TypeEntry/TypeInfo/ObjInspector all implement PrimitiveTypeSoec interface, use in object inspector factory GenericUDFBridge/Macro should be allowed to use SettableUDF moved a few files/methods
          Hide
          phabricator@reviews.facebook.net Phabricator added a comment -

          jdere has commented on the revision "HIVE-5206 [jira] Support parameterized primitive types".

          INLINE COMMENTS
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:776 Ok, will move it to TypeInfoUtils in the next patch
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1279 I suppose it could, I'll add the check to this method.
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1283 Hadn't even heard of macros until now .. sure I suppose it might have some use, will add in the next patch.
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1298 Will change in next patch.
          ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:23 will change.
          ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5332 will move this method in the next patch.
          ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:647 will change in next patch.
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java:99 If Kyro does not call the get()/set() methods to deserialize, then this might help. However if there is a setting to configure the plan serialization, then we can't guarantee that Kyro will always be used
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java:64 Actually, it is not ok to swallow the exception - my latest patch for HIVE-4844 has changed this to re-throw the exception. Do you want me to change it here (this code would never get called in trunk), or is it ok to leave this change in HIVE-4844?
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:215 There are quite a few different callers of this method, they don't always have a TypeInfo. They will usually have 1 of the 3 types:

          • PrimitiveTypeInfo
          • PrimitiveObjectInspector
          • PrimitiveTypeEntry

          All 3 of these types have (PrimitiveCategory, TypeParams). How about I define a interface (PrimitiveTypeSpec?) that can retrieve PrimitiveCategory/TypeParams, and have each of these 3 types implement that interface. And then change this method to take in a PrimitiveTypeSpec as a param.

          REVISION DETAIL
          https://reviews.facebook.net/D12693

          BRANCH
          HIVE-5206

          ARCANIST PROJECT
          hive

          To: JIRA, ashutoshc, jdere

          Show
          phabricator@reviews.facebook.net Phabricator added a comment - jdere has commented on the revision " HIVE-5206 [jira] Support parameterized primitive types". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:776 Ok, will move it to TypeInfoUtils in the next patch ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1279 I suppose it could, I'll add the check to this method. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1283 Hadn't even heard of macros until now .. sure I suppose it might have some use, will add in the next patch. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1298 Will change in next patch. ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:23 will change. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5332 will move this method in the next patch. ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:647 will change in next patch. serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java:99 If Kyro does not call the get()/set() methods to deserialize, then this might help. However if there is a setting to configure the plan serialization, then we can't guarantee that Kyro will always be used serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java:64 Actually, it is not ok to swallow the exception - my latest patch for HIVE-4844 has changed this to re-throw the exception. Do you want me to change it here (this code would never get called in trunk), or is it ok to leave this change in HIVE-4844 ? serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:215 There are quite a few different callers of this method, they don't always have a TypeInfo. They will usually have 1 of the 3 types: PrimitiveTypeInfo PrimitiveObjectInspector PrimitiveTypeEntry All 3 of these types have (PrimitiveCategory, TypeParams). How about I define a interface (PrimitiveTypeSpec?) that can retrieve PrimitiveCategory/TypeParams, and have each of these 3 types implement that interface. And then change this method to take in a PrimitiveTypeSpec as a param. REVISION DETAIL https://reviews.facebook.net/D12693 BRANCH HIVE-5206 ARCANIST PROJECT hive To: JIRA, ashutoshc, jdere
          Hide
          phabricator@reviews.facebook.net Phabricator added a comment -

          ashutoshc has requested changes to the revision "HIVE-5206 [jira] Support parameterized primitive types".

          Awesome comments. Thanks for taking time to put in informative comments!

          INLINE COMMENTS
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:215 I think its better that this method just takes primitiveInfo as an input, because both category and typeParams can be derived from it. Advantage of that is instead of callers providing two arguments, they can just pass in one.
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:776 This utility method should be in TypeInfoUtilities class, not in Function Registry.
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1279 Can't this genericUDF implement SettableUDF ?
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1283 Are macros not suppose to implement SettableUDF?
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1298 I think this is an error condition, we can't swallow the exception here.
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1273 In a follow-up jira we should consider cloning object using Kryo, instead of this reflection based approach. Since Kryo does field base serialization, it is much more faithful in reproducing the state of object than this reflection based approach.
          ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:18 This interface belongs in o.a.h.ql.udf
          ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:23 We need to explicitly annotate this interface to be private, unstable.
          ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5332 Instead of increasing the size of SemanticAnalyzer, this really belongs to ParseUtils.
          ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:647 This could just be package private instead of public.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:313 As stated in previous comment, this could just take in PrimitiveTypeEntry as one parameter.
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java:144 TypeInfo contains both category as well as typeParams, so consider passing just that as an argument.
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java:99 Now with Kryo, does that improve things ?
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java:64 Not sure if we can swallow exception here or we need to throw. Can you add a comment why is it ok to do so?

          REVISION DETAIL
          https://reviews.facebook.net/D12693

          BRANCH
          HIVE-5206

          ARCANIST PROJECT
          hive

          To: JIRA, ashutoshc, jdere

          Show
          phabricator@reviews.facebook.net Phabricator added a comment - ashutoshc has requested changes to the revision " HIVE-5206 [jira] Support parameterized primitive types". Awesome comments. Thanks for taking time to put in informative comments! INLINE COMMENTS serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:215 I think its better that this method just takes primitiveInfo as an input, because both category and typeParams can be derived from it. Advantage of that is instead of callers providing two arguments, they can just pass in one. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:776 This utility method should be in TypeInfoUtilities class, not in Function Registry. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1279 Can't this genericUDF implement SettableUDF ? ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1283 Are macros not suppose to implement SettableUDF? ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1298 I think this is an error condition, we can't swallow the exception here. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1273 In a follow-up jira we should consider cloning object using Kryo, instead of this reflection based approach. Since Kryo does field base serialization, it is much more faithful in reproducing the state of object than this reflection based approach. ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:18 This interface belongs in o.a.h.ql.udf ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:23 We need to explicitly annotate this interface to be private, unstable. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5332 Instead of increasing the size of SemanticAnalyzer, this really belongs to ParseUtils. ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:647 This could just be package private instead of public. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:313 As stated in previous comment, this could just take in PrimitiveTypeEntry as one parameter. serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java:144 TypeInfo contains both category as well as typeParams, so consider passing just that as an argument. serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java:99 Now with Kryo, does that improve things ? serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java:64 Not sure if we can swallow exception here or we need to throw. Can you add a comment why is it ok to do so? REVISION DETAIL https://reviews.facebook.net/D12693 BRANCH HIVE-5206 ARCANIST PROJECT hive To: JIRA, ashutoshc, jdere
          Hide
          jdere Jason Dere added a comment -

          Rebased against trunk, attaching HIVE-5206.2.patch

          Show
          jdere Jason Dere added a comment - Rebased against trunk, attaching HIVE-5206 .2.patch
          Hide
          jdere Jason Dere added a comment -

          Ran unit tests with patches for 5203/5204/5206 applied:

          Tests Failures Errors Success rate Time
          2882 4 0 99.86% 36460.953

          The 4 failures were the typical ones that fail on Mac: escape1.q,escape2.q,udf_translate.q,describe_comment_nonascii.q
          Running these 4 tests on Linux passed.

          Show
          jdere Jason Dere added a comment - Ran unit tests with patches for 5203/5204/5206 applied: Tests Failures Errors Success rate Time 2882 4 0 99.86% 36460.953 The 4 failures were the typical ones that fail on Mac: escape1.q,escape2.q,udf_translate.q,describe_comment_nonascii.q Running these 4 tests on Linux passed.
          Hide
          xuefuz Xuefu Zhang added a comment -

          I think it might be a good idea to file a separate, followup JIRA addressing Ed's suggestion about unifying integers. I can see that there is a slight difference between different types of integers and other parameterized types. Existing integer types can be imaged to be integer type with the number of bytes as a parameter. However, the possible values for that parameter is enumerated and limited. It's hard to image that one day Hive will need to support int(3). For char/varchar/decimal, however, there are continuous values on the parameters.

          Having said that, unifying integer types may make the code unify and add ease to understand. To me, it seems a nice thing to have.

          Show
          xuefuz Xuefu Zhang added a comment - I think it might be a good idea to file a separate, followup JIRA addressing Ed's suggestion about unifying integers. I can see that there is a slight difference between different types of integers and other parameterized types. Existing integer types can be imaged to be integer type with the number of bytes as a parameter. However, the possible values for that parameter is enumerated and limited. It's hard to image that one day Hive will need to support int(3). For char/varchar/decimal, however, there are continuous values on the parameters. Having said that, unifying integer types may make the code unify and add ease to understand. To me, it seems a nice thing to have.
          Hide
          jdere Jason Dere added a comment -

          Correction - the justification is for decimal, char, varchar, so for a combination of string/numeric types. The "right" way depends on whether the type is a qualified type and requires parameters.

          Not going to indulge the "what if" fantasies here, but would like to point out that decimal/char/varchar are pretty fundamental SQL types which many Hive users are interested in, and I hope this work helps to facilitate that effort. If someone wants to take up the torch on unifying integral types as a part of this work, that is great too if that is the right thing to do.

          Show
          jdere Jason Dere added a comment - Correction - the justification is for decimal, char, varchar, so for a combination of string/numeric types. The "right" way depends on whether the type is a qualified type and requires parameters. Not going to indulge the "what if" fantasies here, but would like to point out that decimal/char/varchar are pretty fundamental SQL types which many Hive users are interested in, and I hope this work helps to facilitate that effort. If someone wants to take up the torch on unifying integral types as a part of this work, that is great too if that is the right thing to do.
          Hide
          appodictic Edward Capriolo added a comment -

          Unifying the integral types is surely out of scope for this issue. However,

          We are making the justification for doing this for string, char, varchar. The same argument would hold for the integral types? I mean if someone was a fresh reader to the code and saw that all the string types work one way, but all the int types work another, what would they conclude is the "right" way?

          Are we thinking too patch driven development? Sure your end goal is to have this varchar support (and it is a good goal and this is a good feature) but who cares about all the existing stuff? Is it not sexy not worth touching? I am just thinking out loud here. But I notice we are starting to add many types, some like decimal are special purpose versions of other types. I want to make sure we are thinking about the big picture here. I am not sure we should just be adding a new type every time there is something we do not like about the existing type. What if someone wants nvarchar, or BigInteger, or BigDecimal?

          Show
          appodictic Edward Capriolo added a comment - Unifying the integral types is surely out of scope for this issue. However, We are making the justification for doing this for string, char, varchar. The same argument would hold for the integral types? I mean if someone was a fresh reader to the code and saw that all the string types work one way, but all the int types work another, what would they conclude is the "right" way? Are we thinking too patch driven development? Sure your end goal is to have this varchar support (and it is a good goal and this is a good feature) but who cares about all the existing stuff? Is it not sexy not worth touching? I am just thinking out loud here. But I notice we are starting to add many types, some like decimal are special purpose versions of other types. I want to make sure we are thinking about the big picture here. I am not sure we should just be adding a new type every time there is something we do not like about the existing type. What if someone wants nvarchar, or BigInteger, or BigDecimal?
          Hide
          jdere Jason Dere added a comment -

          The main intent of this feature is for char/varchar/decimal support. I suppose this could be used in some fashion to unify the integral types, but I think that would mean all integral types would need to use the same java/writable types. Is unifying the integral types something people have been talking about?

          Show
          jdere Jason Dere added a comment - The main intent of this feature is for char/varchar/decimal support. I suppose this could be used in some fashion to unify the integral types, but I think that would mean all integral types would need to use the same java/writable types. Is unifying the integral types something people have been talking about?
          Hide
          appodictic Edward Capriolo added a comment -

          If we are parametrizing the types should we also be unifying all the integral types?

          Show
          appodictic Edward Capriolo added a comment - If we are parametrizing the types should we also be unifying all the integral types?
          Hide
          phabricator@reviews.facebook.net Phabricator added a comment -

          jdere requested code review of "HIVE-5206 [jira] Support parameterized primitive types".

          Reviewers: JIRA

          HIVE-5206: Support parameterized primitive types - Add parameterized types - type casts with parameterized types should use SettableUDF interface

          Support for parameterized types is needed for char/varchar/decimal support. This adds a type parameters value to the PrimitiveTypeEntry/PrimitiveTypeInfo/PrimitiveObjectInspector objects.

          NO PRECOMMIT TESTS - dependent on HIVE-5203/HIVE-5204

          TEST PLAN
          EMPTY

          REVISION DETAIL
          https://reviews.facebook.net/D12693

          AFFECTED FILES
          contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java
          ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java

          MANAGE HERALD RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/30459/

          To: JIRA, jdere

          Show
          phabricator@reviews.facebook.net Phabricator added a comment - jdere requested code review of " HIVE-5206 [jira] Support parameterized primitive types". Reviewers: JIRA HIVE-5206 : Support parameterized primitive types - Add parameterized types - type casts with parameterized types should use SettableUDF interface Support for parameterized types is needed for char/varchar/decimal support. This adds a type parameters value to the PrimitiveTypeEntry/PrimitiveTypeInfo/PrimitiveObjectInspector objects. NO PRECOMMIT TESTS - dependent on HIVE-5203 / HIVE-5204 TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12693 AFFECTED FILES contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/30459/ To: JIRA, jdere
          Hide
          jdere Jason Dere added a comment -
          Show
          jdere Jason Dere added a comment - review at https://reviews.facebook.net/D12693
          Hide
          jdere Jason Dere added a comment -

          Attaching HIVE-5206.1.patch.

          Show
          jdere Jason Dere added a comment - Attaching HIVE-5206 .1.patch.

            People

            • Assignee:
              jdere Jason Dere
              Reporter:
              jdere Jason Dere
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development