jdere has commented on the revision "
HIVE-5206 [jira] Support parameterized primitive types".
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:776 Ok, will move it to TypeInfoUtils in the next patch
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1279 I suppose it could, I'll add the check to this method.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1283 Hadn't even heard of macros until now .. sure I suppose it might have some use, will add in the next patch.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1298 Will change in next patch.
ql/src/java/org/apache/hadoop/hive/ql/exec/SettableUDF.java:23 will change.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:5332 will move this method in the next patch.
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:647 will change in next patch.
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java:99 If Kyro does not call the get()/set() methods to deserialize, then this might help. However if there is a setting to configure the plan serialization, then we can't guarantee that Kyro will always be used
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java:64 Actually, it is not ok to swallow the exception - my latest patch for
HIVE-4844 has changed this to re-throw the exception. Do you want me to change it here (this code would never get called in trunk), or is it ok to leave this change in HIVE-4844?
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java:215 There are quite a few different callers of this method, they don't always have a TypeInfo. They will usually have 1 of the 3 types:
All 3 of these types have (PrimitiveCategory, TypeParams). How about I define a interface (PrimitiveTypeSpec?) that can retrieve PrimitiveCategory/TypeParams, and have each of these 3 types implement that interface. And then change this method to take in a PrimitiveTypeSpec as a param.
To: JIRA, ashutoshc, jdere