jdere has commented on the revision "
HIVE-4844 [jira] Add varchar data type".
Most of the SerDe support has been broken out into
HIVE-5161. The SerDe's I'm testing there are RegexSerDe, LazyBinarySerDe, LazySimpleSerDe, ColumnarSerDe, LazyBinaryColumnarSerDe, OrcSerDe. I'll need to take a look again, but if HBase/Avro SerDe's use reflection-based methods to get their Types/ObjectInspectors, then they won't be able to support varchars properly.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 will change in the next patch
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 will change in next patch
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 will change in next patch
ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 sure, will change
ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 will change this message too
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 whoops forgot to add that .. will do
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 Actually, my latest patch did mark these fields as transient .. I'll need to update this review with the updated patch.
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 Do we need to serialize object inspectors? my impression is that should always have been transient, at least when they're used in UDFs since they can be set during initialize().
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 Yeah, this comment is gone in the updated patch.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 2011 SQL Standard (6.13 cast specification) does say that the value should be "TRUE"/"FALSE". This also matches what we're doing with the string type.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 ok, will change
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 will change
To: JIRA, jdere