Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4923

Provide compile + run method for HiveServer2

Details

    • Improvement
    • Status: Patch Available
    • Trivial
    • Resolution: Unresolved
    • None
    • None
    • HiveServer2
    • None

    Description

      Make additional thrift method for asynchronous execution.

      execute=compile+run

      This addresses same thing with HIVE-4569 but with simpler implementation. It's just for reference (We are using this for months).

      Attachments

        1. HIVE-4923.D11781.1.patch
          259 kB
          Phabricator
        2. HIVE-4923.2.patch.txt
          314 kB
          Navis Ryu

        Issue Links

          Activity

            phabricator@reviews.facebook.net Phabricator added a comment -

            navis requested code review of "HIVE-4923 [jira] Provide compile + run method for HiveServer2".

            Reviewers: JIRA

            HIVE-2684 Provide compile + run method for HiveServer2 interface

            Make additional thrift method for asynchronous execution.

            execute=compile+run

            This addresses same thing with HIVE-4569 but with simpler implementation. It's just for reference (We are using this for months).

            TEST PLAN
            EMPTY

            REVISION DETAIL
            https://reviews.facebook.net/D11781

            AFFECTED FILES
            jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
            jdbc/src/java/org/apache/hive/jdbc/Utils.java
            ql/src/gen/thrift/gen-cpp/queryplan_types.cpp
            ql/src/gen/thrift/gen-cpp/queryplan_types.h
            ql/src/gen/thrift/gen-php/Types.php
            ql/src/gen/thrift/gen-py/queryplan/ttypes.py
            ql/src/gen/thrift/gen-rb/queryplan_types.rb
            ql/src/java/org/apache/hadoop/hive/ql/Driver.java
            ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
            ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
            service/if/TCLIService.thrift
            service/src/gen/thrift/gen-cpp/TCLIService.cpp
            service/src/gen/thrift/gen-cpp/TCLIService.h
            service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp
            service/src/gen/thrift/gen-cpp/TCLIService_types.cpp
            service/src/gen/thrift/gen-cpp/TCLIService_types.h
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCompileReq.java
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCompileRes.java
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOperationState.java
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRunReq.java
            service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRunRes.java
            service/src/gen/thrift/gen-php/TCLIService.php
            service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote
            service/src/gen/thrift/gen-py/TCLIService/TCLIService.py
            service/src/gen/thrift/gen-py/TCLIService/ttypes.py
            service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote
            service/src/gen/thrift/gen-rb/t_c_l_i_service.rb
            service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb
            service/src/java/org/apache/hive/service/cli/CLIService.java
            service/src/java/org/apache/hive/service/cli/CLIServiceClient.java
            service/src/java/org/apache/hive/service/cli/CompileResult.java
            service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java
            service/src/java/org/apache/hive/service/cli/ICLIService.java
            service/src/java/org/apache/hive/service/cli/OperationState.java
            service/src/java/org/apache/hive/service/cli/Row.java
            service/src/java/org/apache/hive/service/cli/RowSet.java
            service/src/java/org/apache/hive/service/cli/TableSchema.java
            service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
            service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
            service/src/java/org/apache/hive/service/cli/session/HiveSession.java
            service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
            service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
            service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java

            MANAGE HERALD RULES
            https://reviews.facebook.net/herald/view/differential/

            WHY DID I GET THIS EMAIL?
            https://reviews.facebook.net/herald/transcript/28017/

            To: JIRA, navis

            phabricator@reviews.facebook.net Phabricator added a comment - navis requested code review of " HIVE-4923 [jira] Provide compile + run method for HiveServer2". Reviewers: JIRA HIVE-2684 Provide compile + run method for HiveServer2 interface Make additional thrift method for asynchronous execution. execute=compile+run This addresses same thing with HIVE-4569 but with simpler implementation. It's just for reference (We are using this for months). TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D11781 AFFECTED FILES jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java jdbc/src/java/org/apache/hive/jdbc/Utils.java ql/src/gen/thrift/gen-cpp/queryplan_types.cpp ql/src/gen/thrift/gen-cpp/queryplan_types.h ql/src/gen/thrift/gen-php/Types.php ql/src/gen/thrift/gen-py/queryplan/ttypes.py ql/src/gen/thrift/gen-rb/queryplan_types.rb ql/src/java/org/apache/hadoop/hive/ql/Driver.java ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java service/if/TCLIService.thrift service/src/gen/thrift/gen-cpp/TCLIService.cpp service/src/gen/thrift/gen-cpp/TCLIService.h service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp service/src/gen/thrift/gen-cpp/TCLIService_types.cpp service/src/gen/thrift/gen-cpp/TCLIService_types.h service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCompileReq.java service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCompileRes.java service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOperationState.java service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRunReq.java service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRunRes.java service/src/gen/thrift/gen-php/TCLIService.php service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote service/src/gen/thrift/gen-py/TCLIService/TCLIService.py service/src/gen/thrift/gen-py/TCLIService/ttypes.py service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote service/src/gen/thrift/gen-rb/t_c_l_i_service.rb service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb service/src/java/org/apache/hive/service/cli/CLIService.java service/src/java/org/apache/hive/service/cli/CLIServiceClient.java service/src/java/org/apache/hive/service/cli/CompileResult.java service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java service/src/java/org/apache/hive/service/cli/ICLIService.java service/src/java/org/apache/hive/service/cli/OperationState.java service/src/java/org/apache/hive/service/cli/Row.java service/src/java/org/apache/hive/service/cli/RowSet.java service/src/java/org/apache/hive/service/cli/TableSchema.java service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java service/src/java/org/apache/hive/service/cli/session/HiveSession.java service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/28017/ To: JIRA, navis
            navis Navis Ryu added a comment -

            Seemed replaced by asynchronous execution in hiveserver2. Closing the issue.

            navis Navis Ryu added a comment - Seemed replaced by asynchronous execution in hiveserver2. Closing the issue.
            navis Navis Ryu added a comment -

            Seemed still useful for some cases. especially with HIVE-3946.

            navis Navis Ryu added a comment - Seemed still useful for some cases. especially with HIVE-3946 .
            hiveqa Hive QA added a comment -

            Overall: -1 at least one tests failed

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12685978/HIVE-4923.2.patch.txt

            ERROR: -1 due to 2 failed/errored test(s), 6700 tests executed
            Failed tests:

            org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx_cbo_1
            org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit
            

            Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2007/testReport
            Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2007/console
            Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2007/

            Messages:

            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            Tests exited with: TestsFailedException: 2 tests failed
            

            This message is automatically generated.

            ATTACHMENT ID: 12685978 - PreCommit-HIVE-TRUNK-Build

            hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12685978/HIVE-4923.2.patch.txt ERROR: -1 due to 2 failed/errored test(s), 6700 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx_cbo_1 org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2007/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2007/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2007/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12685978 - PreCommit-HIVE-TRUNK-Build

            People

              navis Navis Ryu
              navis Navis Ryu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: