[HIVE-27103] Thrift compilation warnings on drop_dataconnector()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-beta-1
• Labels: pull-request-available
• Assignee: Quanlong Huang
• Reporter: Quanlong Huang
• Created: 24/Feb/23 02:05
• Updated: 15/Aug/23 06:33
• Resolved: 02/Mar/23 06:41

Description

We see compilation warnings when compiling Impala with hive_metastore.thrift

[WARNING:/home/quanlong/workspace/Impala/toolchain/cdp_components-36109364/hive-3.1.3000.7.2.17.0-75/standalone-metastore/src/main/thrift/hive_metastore.thrift:2397] No field key specified for ifNotExists, resulting protocol may have conflicts or not be backwards compatible!

[WARNING:/home/quanlong/workspace/Impala/toolchain/cdp_components-36109364/hive-3.1.3000.7.2.17.0-75/standalone-metastore/src/main/thrift/hive_metastore.thrift:2397] No field key specified for checkReferences, resulting protocol may have conflicts or not be backwards compatible!

A code snipper arround line 2397:

2395   void create_dataconnector(1:DataConnector connector) throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2, 3:MetaException o3)
2396   DataConnector get_dataconnector_req(1:GetDataConnectorRequest request) throws(1:NoSuchObjectException o1, 2:MetaException o2)
2397   void drop_dataconnector(1:string name, bool ifNotExists, bool checkReferences) throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
2398   list<string> get_dataconnectors() throws(1:MetaException o1)

The arguments of drop_dataconnector() should have indexes, but only the first argument 'name' has an index.

Issue Links

• is related to: IMPALA-12059 Make Thrift compilation stop spewing warnings
• is related to: HIVE-27396 Use -strict argument for Thrift code generation to prevent compatibility issues
• links to: GitHub Pull Request #4080