[HIVE-27396] Use -strict argument for Thrift code generation to prevent compatibility issues

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: Build Infrastructure
• Labels: pull-request-available
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 31/May/23 23:04
• Updated: 29/Mar/24 17:49
• Resolved: 10/Aug/23 12:27

Description

When generating code, the Thrift compiler has a "-strict" option that errors out for certain warnings. Specifically, it errors out when there are implicit field keys:

        pwarning(1, "No field key specified for %s, resulting protocol may have conflicts or not be backwards compatible!\n", $6);
        if (g_strict >= 192) {
          yyerror("Implicit field keys are deprecated and not allowed with -strict");
          exit(1);
        }

https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/thrifty.yy#L824-L828

This is a warning that has been introduced in the past (see HIVE-27103 and HIVE-20365)

I think that it would be useful to add "-strict" to the arguments for Thrift code generation. It would prevent the introduction of new compatibility issues, because the command would fail rather than generating a warning that is easy to miss.

The current Thrift files already work with -strict, so this should be a painless thing.

Issue Links

• relates to: HIVE-20365 Fix warnings when regenerating thrift code
• relates to: HIVE-27103 Thrift compilation warnings on drop_dataconnector()
• links to: GitHub Pull Request #4568