[HIVE-25952] Drop HiveRelMdPredicates::getPredicates(Project...) to use that of RelMdPredicates

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.0.0
• Component/s: CBO
• Labels: pull-request-available
• Assignee: Alessandro Solimando
• Reporter: Alessandro Solimando
• Created: 11/Feb/22 11:37
• Updated: 01/Dec/24 00:33

Description

There are some differences on this method between Hive and Calcite, the idea of this ticket is to unify the two methods, and then drop the override in HiveRelMdPredicates in favour of the method of RelMdPredicates.

After applying HIVE-25966, the only difference is in the test for constant expressions, which can be summarized as follows:

Expression Type	Is Constant for Hive?	Is Constant for Calcite?
InputRef	False	False
Call	True if function is deterministic (arguments are not checked), false otherwise	True if function is deterministic and all operands are constants, false otherwise
CorrelatedVariable	False	False
LocalRef	False	False
Over	False	False
DymanicParameter	False	True
RangeRef	False	False
FieldAccess	False	Given expr.field, true if expr is constant, false otherwise

Issue Links

• fixes: HIVE-26733 Not safe to use '=' for predicates on constant expressions that might be NULL
• is blocked by: HIVE-25966 Align HiveRelMdPredicates getPredicates() for Project with RelMdPredicates
• links to: GitHub Pull Request #3023
• links to: GitHub Pull Request #3024
• links to: GitHub Pull Request #3025
• links to: GitHub Pull Request #5360