[HIVE-23389] FilterMergeRule can lead to AssertionError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: CBO
• Labels: pull-request-available
• Assignee: Jesús Camacho Rodríguez
• Reporter: Jesús Camacho Rodríguez
• Created: 06/May/20 23:04
• Updated: 27/Feb/24 22:24
• Resolved: 11/May/20 14:13

Description

I have not been able to reproduce the issue in latest master. However, this could potentially happen since Filter creation has a check on whether the expression is flat (here) and Filter merge does not flatten an expression when it is created.

java.lang.AssertionError: AND(=($3, 100), OR(OR(null, IS NOT NULL(CAST(100):INTEGER)), =(CAST(100):INTEGER, CAST(200):INTEGER)))
	at org.apache.calcite.rel.core.Filter.<init>(Filter.java:74)
	at org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveFilter.<init>(HiveFilter.java:39)
	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveFilterFactoryImpl.createFilter(HiveRelFactories.java:126)
	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelBuilder.filter(HiveRelBuilder.java:99)
	at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:1055)
	at org.apache.calcite.rel.rules.FilterMergeRule.onMatch(FilterMergeRule.java:81)

Issue Links

• is related to: CALCITE-3982 Simplify FilterMergeRule to rely on RelBuilder instead of RexProgram
• is related to: HIVE-26642 Replace HiveFilterMergeRule with Calcite's built-in implementation
• links to: GitHub Pull Request #1010