[CALCITE-3982] Simplify FilterMergeRule to rely on RelBuilder instead of RexProgram

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.23.0
• Component/s: core
• Assignee: Jesus Camacho Rodriguez
• Reporter: Jesus Camacho Rodriguez
• Created: 08/May/20 19:44
• Updated: 23/Feb/22 10:27
• Resolved: 11/May/20 14:50

Description

This could potentially happen since Filter creation has a check on whether the expression is flat (here) and Filter merge does not flatten an expression when it is created.

java.lang.AssertionError: AND(=($3, 100), OR(OR(null, IS NOT NULL(CAST(100):INTEGER)), =(CAST(100):INTEGER, CAST(200):INTEGER)))
	at org.apache.calcite.rel.core.Filter.<init>(Filter.java:74)
	at org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveFilter.<init>(HiveFilter.java:39)
	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveFilterFactoryImpl.createFilter(HiveRelFactories.java:126)
	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelBuilder.filter(HiveRelBuilder.java:99)
	at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:1055)
	at org.apache.calcite.rel.rules.FilterMergeRule.onMatch(FilterMergeRule.java:81)

Issue Links

• blocks: HIVE-25974 Drop HiveFilterMergeRule and use FilterMergeRule from Calcite
• relates to: HIVE-23389 FilterMergeRule can lead to AssertionError