[HIVE-23354] Remove file size sanity checking from compareTempOrDuplicateFiles

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: HiveServer2
• Labels: pull-request-available
• Target Version/s: 4.0.0
• Assignee: John Sherman
• Reporter: John Sherman
• Created: 02/May/20 02:22
• Updated: 27/Feb/24 22:23
• Resolved: 18/May/20 20:20

Description

https://github.com/apache/hive/blob/cdd55aa319a3440963a886ebfff11cd2a240781d/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L1952-L2010
compareTempOrDuplicateFiles uses a combination of attemptId and fileSize to determine which file(s) to keep.
I've seen instances where this function throws an exception due to the fact that the newer attemptId file size is less than the older attemptId (thus failing the query).
I think this assumption is faulty, due to various factors such as file compression and the order in which values are written. It may be prudent to trust that the newest attemptId is in fact the best choice.

Issue Links

• causes: HIVE-23614 Always pass HiveConfig to removeTempOrDuplicateFiles
• links to: GitHub Pull Request #1022