Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-22419

Improve Messages Emitted From HiveMetaStoreClient

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.2.0, 4.0.0
    • 4.0.0-alpha-1
    • Standalone Metastore
    • None

    Description

      After reviewing some logs and errors emitted during a QTest run, I would like to propose some improvements to logging in HiveMetaStoreClient.

      • Remove duplicate logging
      • Remove superfluous class StackTraceLogger
      • Do not use contractions in public-facing error messages and logs
      • Make all logging side-effect free (see connCount)
      • Code simplification

      Attachments

        1. HIVE-22419.1.patch
          8 kB
          David Mollitor

        Issue Links

          Activity

            hiveqa Hive QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
                  master Compile Tests
            +1 mvninstall 12m 25s master passed
            +1 compile 0m 47s master passed
            +1 checkstyle 0m 18s master passed
            0 findbugs 3m 34s standalone-metastore/metastore-common in master has 37 extant Findbugs warnings.
            +1 javadoc 1m 23s master passed
                  Patch Compile Tests
            +1 mvninstall 0m 49s the patch passed
            +1 compile 0m 52s the patch passed
            +1 javac 0m 52s the patch passed
            +1 checkstyle 0m 16s standalone-metastore/metastore-common: The patch generated 0 new + 215 unchanged - 2 fixed = 215 total (was 217)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 findbugs 3m 41s the patch passed
            +1 javadoc 1m 23s the patch passed
                  Other Tests
            +1 asflicense 0m 22s The patch does not generate ASF License warnings.
            26m 39s



            Subsystem Report/Notes
            Optional Tests asflicense javac javadoc findbugs checkstyle compile
            uname Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux
            Build tool maven
            Personality /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19201/dev-support/hive-personality.sh
            git revision master / 305e710
            Default Java 1.8.0_111
            findbugs v3.0.0
            modules C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common
            Console output http://104.198.109.242/logs//PreCommit-HIVE-Build-19201/yetus.txt
            Powered by Apache Yetus http://yetus.apache.org

            This message was automatically generated.

            hiveqa Hive QA added a comment - +1 overall Vote Subsystem Runtime Comment       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       master Compile Tests +1 mvninstall 12m 25s master passed +1 compile 0m 47s master passed +1 checkstyle 0m 18s master passed 0 findbugs 3m 34s standalone-metastore/metastore-common in master has 37 extant Findbugs warnings. +1 javadoc 1m 23s master passed       Patch Compile Tests +1 mvninstall 0m 49s the patch passed +1 compile 0m 52s the patch passed +1 javac 0m 52s the patch passed +1 checkstyle 0m 16s standalone-metastore/metastore-common: The patch generated 0 new + 215 unchanged - 2 fixed = 215 total (was 217) +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 41s the patch passed +1 javadoc 1m 23s the patch passed       Other Tests +1 asflicense 0m 22s The patch does not generate ASF License warnings. 26m 39s Subsystem Report/Notes Optional Tests asflicense javac javadoc findbugs checkstyle compile uname Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux Build tool maven Personality /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19201/dev-support/hive-personality.sh git revision master / 305e710 Default Java 1.8.0_111 findbugs v3.0.0 modules C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common Console output http://104.198.109.242/logs//PreCommit-HIVE-Build-19201/yetus.txt Powered by Apache Yetus http://yetus.apache.org This message was automatically generated.
            hiveqa Hive QA added a comment -

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12984282/HIVE-22419.1.patch

            ERROR: -1 due to no test(s) being added or modified.

            SUCCESS: +1 due to 17546 tests passed

            Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/testReport
            Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/console
            Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19201/

            Messages:

            Executing org.apache.hive.ptest.execution.TestCheckPhase
            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.YetusPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            

            This message is automatically generated.

            ATTACHMENT ID: 12984282 - PreCommit-HIVE-Build

            hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12984282/HIVE-22419.1.patch ERROR: -1 due to no test(s) being added or modified. SUCCESS: +1 due to 17546 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19201/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19201/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12984282 - PreCommit-HIVE-Build

            +1

            ashutoshc Ashutosh Chauhan added a comment - +1

            Pushed to master. Thanks, David!

            ashutoshc Ashutosh Chauhan added a comment - Pushed to master. Thanks, David!

            People

              belugabehr David Mollitor
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: