Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18882

Do Not Hide Exception in Hive Metastore Client Connection

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: Standalone Metastore
    • Labels:

      Description

      https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531

       

      if (LOG.isDebugEnabled()) {
        LOG.warn("Failed to connect to the MetaStore Server...", e);
      } else {
        // Don't print full exception trace if DEBUG is not on.
        LOG.warn("Failed to connect to the MetaStore Server...");
      }
      

      I do not understand the logic here. I always want to see the reason for the failure. Otherwise, I do not know why it is failing unless I restart the server with debug logging enabled. By that point, the error may have cleared. Please just use the Exception in the WARN output without adding confusing logging for debugging. This is never an expected behavior... that enabling debug would change a warn level log message.

      Also... please remove the ellipsis, they add no value.

        Attachments

        1. HIVE-18882.1.patch
          1 kB
          Manoj Narayanan
        2. HIVE-18882.2.patch
          1 kB
          Manoj Narayanan
        3. HIVE-18882.patch
          1 kB
          Manoj Narayanan

          Activity

            People

            • Assignee:
              mnarayanan2018 Manoj Narayanan
              Reporter:
              belugabehr BELUGA BEHR
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: