[HIVE-18882] Minor Logging Improvements in Hive Metastore Client Connection

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Standalone Metastore
• Labels: noob
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 06/Mar/18 22:51
• Updated: 17/Nov/22 08:55
• Resolved: 15/May/20 13:50

Description

https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531

 

if (LOG.isDebugEnabled()) {
  LOG.warn("Failed to connect to the MetaStore Server...", e);
} else {
  // Don't print full exception trace if DEBUG is not on.
  LOG.warn("Failed to connect to the MetaStore Server...");
}

I do not understand the logic here. I always want to see the reason for the failure. Otherwise, I do not know why it is failing unless I restart the server with debug logging enabled. By that point, the error may have cleared. Please just use the Exception in the WARN output without adding confusing logging for debugging. This is never an expected behavior... that enabling debug would change a warn level log message.

Also... please remove the ellipsis, they add no value.

Issue Links

• is superceded by: HIVE-22419 Improve Messages Emitted From HiveMetaStoreClient