Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.0.0
Description
if (LOG.isDebugEnabled()) { LOG.warn("Failed to connect to the MetaStore Server...", e); } else { // Don't print full exception trace if DEBUG is not on. LOG.warn("Failed to connect to the MetaStore Server..."); }
I do not understand the logic here. I always want to see the reason for the failure. Otherwise, I do not know why it is failing unless I restart the server with debug logging enabled. By that point, the error may have cleared. Please just use the Exception in the WARN output without adding confusing logging for debugging. This is never an expected behavior... that enabling debug would change a warn level log message.
Also... please remove the ellipsis, they add no value.
Attachments
Attachments
- HIVE-18882.patch
- 1 kB
- Manoj Narayanan
- HIVE-18882.5.patch
- 3 kB
- David Mollitor
- HIVE-18882.5.patch
- 3 kB
- David Mollitor
- HIVE-18882.4.patch
- 7 kB
- David Mollitor
- HIVE-18882.3.patch
- 6 kB
- David Mollitor
- HIVE-18882.2.patch
- 1 kB
- Manoj Narayanan
- HIVE-18882.1.patch
- 1 kB
- Manoj Narayanan
Issue Links
- is superceded by
-
HIVE-22419 Improve Messages Emitted From HiveMetaStoreClient
- Closed
Activity
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 8m 0s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 0m 18s | master passed |
0 | findbugs | 3m 11s | standalone-metastore in master has 227 extant Findbugs warnings. |
+1 | javadoc | 0m 59s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 49s | the patch passed |
+1 | compile | 0m 40s | the patch passed |
+1 | javac | 0m 40s | the patch passed |
+1 | checkstyle | 0m 19s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 3m 19s | the patch passed |
+1 | javadoc | 0m 55s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
19m 45s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11945/dev-support/hive-personality.sh |
git revision | master / 52f190e |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore U: standalone-metastore |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11945/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928306/HIVE-18882.patch
ERROR: -1 due to no test(s) being added or modified.
ERROR: -1 due to 1 failed/errored test(s), 14533 tests executed
Failed tests:
org.apache.hadoop.hive.metastore.client.TestRuntimeStats.testCleanup[Embedded] (batchId=212)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11945/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11945/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11945/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed
This message is automatically generated.
ATTACHMENT ID: 12928306 - PreCommit-HIVE-Build
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 1s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 7m 42s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 0m 18s | master passed |
0 | findbugs | 3m 8s | standalone-metastore in master has 228 extant Findbugs warnings. |
+1 | javadoc | 0m 54s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 48s | the patch passed |
+1 | compile | 0m 37s | the patch passed |
+1 | javac | 0m 37s | the patch passed |
+1 | checkstyle | 0m 19s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 3m 9s | the patch passed |
+1 | javadoc | 1m 0s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
19m 16s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12054/dev-support/hive-personality.sh |
git revision | master / 4b7f88a |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore U: standalone-metastore |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12054/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928876/HIVE-18882.1.patch
ERROR: -1 due to no test(s) being added or modified.
ERROR: -1 due to 9 failed/errored test(s), 14517 tests executed
Failed tests:
TestBeeLineExceptionHandling - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestBeeLineHistory - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestBeelineArgParsing - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestClientCommandHookFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestHiveCli - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestHiveSchemaTool - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestIncrementalRows - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestShutdownHook - did not produce a TEST-*.xml file (likely timed out) (batchId=193) TestTableOutputFormat - did not produce a TEST-*.xml file (likely timed out) (batchId=193)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12054/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12054/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12054/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed
This message is automatically generated.
ATTACHMENT ID: 12928876 - PreCommit-HIVE-Build
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 7m 54s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 0m 18s | master passed |
0 | findbugs | 3m 6s | standalone-metastore in master has 228 extant Findbugs warnings. |
+1 | javadoc | 0m 55s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 49s | the patch passed |
+1 | compile | 0m 42s | the patch passed |
+1 | javac | 0m 42s | the patch passed |
+1 | checkstyle | 0m 19s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 3m 17s | the patch passed |
+1 | javadoc | 0m 53s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
19m 30s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12267/dev-support/hive-personality.sh |
git revision | master / 761597f |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore U: standalone-metastore |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12267/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12929527/HIVE-18882.2.patch
ERROR: -1 due to no test(s) being added or modified.
SUCCESS: +1 due to 14632 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12267/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12267/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12267/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
ATTACHMENT ID: 12929527 - PreCommit-HIVE-Build
I do not see a reason why debug needs to be enabled to be able to see the full stack trace. Just a quick followup question though. With the retrying metastore client in HS2, does this exception get logged many times in the HS2 log when HMS is down? Could you test with starting a HS2 or even Hive CLI without a running HMS to see what gets spit out?
Otherwise, change looks good to me. Thanks
ngangam Fair point.
We do print the exception at the end of the method if we are not successful with connecting.
Perhaps just change it to:
LOG.debug("Failed to connect to the MetaStore Server...", e); LOG.warn("Failed to connect to the MetaStore Server...");
Really, this entire method should be re-written. It has try blocks in try blocks, which sometimes logs error conditions, and other times it re-throws the error and is then caught by the outer try block. This method is has very low readability.
Anyway, I updated the patch:
- Log per-attempt error message to screen, include a matching debug log to include the entire stack trace
- Remove an instance where code logs and throws (therefore error is logged twice, once when the original error is caught and logged again by the code catching the re-throw
- Fixed some checkstyle errors
- Use SLF4J paramaterized logged in a few places
- Improve log messages
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 1s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 7m 47s | master passed |
+1 | compile | 0m 28s | master passed |
+1 | checkstyle | 0m 7s | master passed |
0 | findbugs | 2m 16s | standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. |
+1 | javadoc | 0m 48s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 31s | the patch passed |
+1 | compile | 0m 29s | the patch passed |
+1 | javac | 0m 29s | the patch passed |
+1 | checkstyle | 0m 7s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 2m 18s | the patch passed |
+1 | javadoc | 0m 47s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
16m 20s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15134/dev-support/hive-personality.sh |
git revision | master / 270dfa3 |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15134/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12950181/HIVE-18882.3.patch
ERROR: -1 due to no test(s) being added or modified.
SUCCESS: +1 due to 15644 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15134/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15134/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15134/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
ATTACHMENT ID: 12950181 - PreCommit-HIVE-Build
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12950181/HIVE-18882.3.patch
ERROR: -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19393/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19393/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19393/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-11-13 04:23:49.814 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-19393/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-11-13 04:23:49.817 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 9678ca1 HIVE-22469: Lower Metastore DB Connection Pool Size in QTests (David Mollitor, reviewed by Miklos Gergely) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 9678ca1 HIVE-22469: Lower Metastore DB Connection Pool Size in QTests (David Mollitor, reviewed by Miklos Gergely) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-11-13 04:23:50.978 + rm -rf ../yetus_PreCommit-HIVE-Build-19393 + mkdir ../yetus_PreCommit-HIVE-Build-19393 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-19393 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19393/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: does not exist in index error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:533 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java' with conflicts. Going to apply patch with: git apply -p1 error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:533 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java' with conflicts. U standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-19393 + exit 1 '
This message is automatically generated.
ATTACHMENT ID: 12950181 - PreCommit-HIVE-Build
looks good to me +1
LOG.warn("Failed to connect to the MetaStore Server");
however I think exception.getMessage() is not a verbose stuff, maybe it can be written on warn level every time, but that's just my opinion, patch is ok
abstractdog I think that can be addressed in a follow-up JIRA. I think the idea here is that there if there a re-try, you would get the message many times,... right now it's just printed on the final error.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 9m 5s | master passed |
+1 | compile | 0m 33s | master passed |
+1 | checkstyle | 0m 13s | master passed |
0 | findbugs | 2m 32s | standalone-metastore/metastore-common in master has 37 extant Findbugs warnings. |
+1 | javadoc | 0m 58s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 34s | the patch passed |
+1 | compile | 0m 34s | the patch passed |
+1 | javac | 0m 33s | the patch passed |
+1 | checkstyle | 0m 13s | standalone-metastore/metastore-common: The patch generated 0 new + 205 unchanged - 1 fixed = 205 total (was 206) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 2m 43s | the patch passed |
+1 | javadoc | 0m 58s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
19m 7s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19486/dev-support/hive-personality.sh |
git revision | master / 0781cf2 |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19486/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12986143/HIVE-18882.4.patch
ERROR: -1 due to no test(s) being added or modified.
ERROR: -1 due to 1 failed/errored test(s), 17705 tests executed
Failed tests:
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosIncrementalLoadAcidTables.org.apache.hadoop.hive.ql.parse.TestReplicationScenariosIncrementalLoadAcidTables (batchId=273)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19486/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19486/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19486/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed
This message is automatically generated.
ATTACHMENT ID: 12986143 - PreCommit-HIVE-Build
A lot of this work was already covered in HIVE-22419, but there are a couple of little nits from this patch to submit.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 11m 24s | master passed |
+1 | compile | 0m 39s | master passed |
+1 | checkstyle | 0m 14s | master passed |
0 | findbugs | 3m 2s | standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. |
+1 | javadoc | 1m 7s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 41s | the patch passed |
+1 | compile | 0m 40s | the patch passed |
+1 | javac | 0m 40s | the patch passed |
+1 | checkstyle | 0m 14s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 3m 9s | the patch passed |
+1 | javadoc | 1m 5s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
23m 8s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22325/dev-support/hive-personality.sh |
git revision | master / 9f40d7c |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22325/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002844/HIVE-18882.5.patch
ERROR: -1 due to no test(s) being added or modified.
ERROR: -1 due to 1 failed/errored test(s), 17239 tests executed
Failed tests:
TestReplAcidTablesWithJsonMessage - did not produce a TEST-*.xml file (likely timed out) (batchId=199)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22325/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22325/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22325/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed
This message is automatically generated.
ATTACHMENT ID: 13002844 - PreCommit-HIVE-Build
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 11m 29s | master passed |
+1 | compile | 0m 41s | master passed |
+1 | checkstyle | 0m 14s | master passed |
0 | findbugs | 3m 8s | standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. |
+1 | javadoc | 1m 3s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 0m 42s | the patch passed |
+1 | compile | 0m 40s | the patch passed |
+1 | javac | 0m 40s | the patch passed |
+1 | checkstyle | 0m 15s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 3m 15s | the patch passed |
+1 | javadoc | 1m 21s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
23m 33s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22348/dev-support/hive-personality.sh |
git revision | master / 390ad7d |
Default Java | 1.8.0_111 |
findbugs | v3.0.0 |
modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22348/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002957/HIVE-18882.5.patch
ERROR: -1 due to no test(s) being added or modified.
SUCCESS: +1 due to 17269 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22348/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22348/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22348/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
ATTACHMENT ID: 13002957 - PreCommit-HIVE-Build
Removed unnecessary log level check. Please review.